[Rt-commit] rt branch, 4.2/clean-up-columnmap, created. rt-4.1.6-231-g0beb25f
Alex Vandiver
alexmv at bestpractical.com
Sat Feb 9 00:25:44 EST 2013
The branch, 4.2/clean-up-columnmap has been created
at 0beb25f80557c53e01b84cba4203a788044d0bed (commit)
- Log -----------------------------------------------------------------
commit c0297cba38f00d1ec38477df9d2b4eb25ea20194
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Sat Feb 9 00:21:44 2013 -0500
Let the standard "id" column be handled by the generic ColumnMap
Standardize on using "#" as the title of it.
diff --git a/share/html/Elements/ColumnMap b/share/html/Elements/ColumnMap
index 4d6d123..47cdd72 100644
--- a/share/html/Elements/ColumnMap
+++ b/share/html/Elements/ColumnMap
@@ -56,7 +56,7 @@ $Attr => undef
my $COLUMN_MAP = {
id => {
attribute => 'id',
- title => 'id', # loc
+ title => '#', # loc
align => 'right',
value => sub { return $_[0]->id }
},
diff --git a/share/html/Elements/RT__Class/ColumnMap b/share/html/Elements/RT__Class/ColumnMap
index afe89f2..b0f4658 100644
--- a/share/html/Elements/RT__Class/ColumnMap
+++ b/share/html/Elements/RT__Class/ColumnMap
@@ -52,11 +52,6 @@ $GenericMap => {}
</%ARGS>
<%ONCE>
my $COLUMN_MAP = {
- id => {
- title => '#', # loc
- attribute => 'id',
- value => sub { return $_[0]->id },
- },
Name => {
title => 'Name', # loc
attribute => 'Name',
diff --git a/share/html/Elements/RT__CustomField/ColumnMap b/share/html/Elements/RT__CustomField/ColumnMap
index b068631..accd1d7 100644
--- a/share/html/Elements/RT__CustomField/ColumnMap
+++ b/share/html/Elements/RT__CustomField/ColumnMap
@@ -52,12 +52,6 @@ $GenericMap => {}
</%ARGS>
<%ONCE>
my $COLUMN_MAP = {
- id => {
- title => '#', # loc
- attribute => 'id',
- align => 'right',
- value => sub { return $_[0]->id },
- },
Disabled => {
title => \' ',
attribute => 'Disabled',
diff --git a/share/html/Elements/RT__Dashboard/ColumnMap b/share/html/Elements/RT__Dashboard/ColumnMap
index 0d031db..6177d31 100644
--- a/share/html/Elements/RT__Dashboard/ColumnMap
+++ b/share/html/Elements/RT__Dashboard/ColumnMap
@@ -52,12 +52,6 @@ $GenericMap => {}
</%ARGS>
<%ONCE>
my $COLUMN_MAP = {
- id => {
- title => '#', # loc
- attribute => 'id',
- align => 'right',
- value => sub { return $_[0]->Id },
- },
Name => {
title => 'Name', # loc
attribute => 'Name',
diff --git a/share/html/Elements/RT__Group/ColumnMap b/share/html/Elements/RT__Group/ColumnMap
index ea7c560..06d6d60 100644
--- a/share/html/Elements/RT__Group/ColumnMap
+++ b/share/html/Elements/RT__Group/ColumnMap
@@ -52,12 +52,6 @@ $GenericMap => {}
</%ARGS>
<%ONCE>
my $COLUMN_MAP = {
- id => {
- title => '#', # loc
- attribute => 'id',
- align => 'right',
- value => sub { return $_[0]->id },
- },
HasMember => {
title => 'Member', # loc
value => sub {
diff --git a/share/html/Elements/RT__Queue/ColumnMap b/share/html/Elements/RT__Queue/ColumnMap
index 173a16c..504a554 100644
--- a/share/html/Elements/RT__Queue/ColumnMap
+++ b/share/html/Elements/RT__Queue/ColumnMap
@@ -52,12 +52,6 @@ $GenericMap => {}
</%ARGS>
<%ONCE>
my $COLUMN_MAP = {
- id => {
- title => '#', # loc
- attribute => 'id',
- align => 'right',
- value => sub { return $_[0]->id },
- },
Disabled => {
title => \' ',
attribute => 'Disabled',
diff --git a/share/html/Elements/RT__SavedSearch/ColumnMap b/share/html/Elements/RT__SavedSearch/ColumnMap
index 1245554..fb2a648 100644
--- a/share/html/Elements/RT__SavedSearch/ColumnMap
+++ b/share/html/Elements/RT__SavedSearch/ColumnMap
@@ -52,12 +52,6 @@ $GenericMap => {}
</%ARGS>
<%ONCE>
my $COLUMN_MAP = {
- id => {
- title => '#', # loc
- attribute => 'id',
- align => 'right',
- value => sub { return $_[0]->Id },
- },
Name => {
title => 'Name', # loc
attribute => 'Name',
diff --git a/share/html/Elements/RT__Scrip/ColumnMap b/share/html/Elements/RT__Scrip/ColumnMap
index 0dccdc6..4077d4b 100644
--- a/share/html/Elements/RT__Scrip/ColumnMap
+++ b/share/html/Elements/RT__Scrip/ColumnMap
@@ -52,12 +52,6 @@ $GenericMap => {}
</%ARGS>
<%ONCE>
my $COLUMN_MAP = {
- id => {
- title => '#', # loc
- attribute => 'id',
- align => 'right',
- value => sub { return $_[0]->id },
- },
Queue => {
title => 'Queue', # loc
value => sub {
diff --git a/share/html/Elements/RT__Template/ColumnMap b/share/html/Elements/RT__Template/ColumnMap
index 3f4bbed..b1ed8d9 100644
--- a/share/html/Elements/RT__Template/ColumnMap
+++ b/share/html/Elements/RT__Template/ColumnMap
@@ -52,12 +52,6 @@ $GenericMap => {}
</%ARGS>
<%ONCE>
my $COLUMN_MAP = {
- id => {
- title => '#', # loc
- attribute => 'id',
- align => 'right',
- value => sub { return $_[0]->id },
- },
Name => {
title => 'Name', # loc
attribute => 'Name',
diff --git a/share/html/Elements/RT__User/ColumnMap b/share/html/Elements/RT__User/ColumnMap
index 41ef484..a590a93 100644
--- a/share/html/Elements/RT__User/ColumnMap
+++ b/share/html/Elements/RT__User/ColumnMap
@@ -52,12 +52,6 @@ $GenericMap => {}
</%ARGS>
<%ONCE>
my $COLUMN_MAP = {
- id => {
- title => '#', # loc
- attribute => 'id',
- align => 'right',
- value => sub { return $_[0]->id },
- },
Name => {
title => 'Name', # loc
attribute => 'Name',
commit 0beb25f80557c53e01b84cba4203a788044d0bed
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Sat Feb 9 00:25:39 2013 -0500
The generic ColumnMap handles CreatedRelative and LastUpdatedRelative just fine
diff --git a/share/html/Elements/RT__Article/ColumnMap b/share/html/Elements/RT__Article/ColumnMap
index 0123c16..3ae655f 100644
--- a/share/html/Elements/RT__Article/ColumnMap
+++ b/share/html/Elements/RT__Article/ColumnMap
@@ -76,16 +76,6 @@ $COLUMN_MAP = {
title => 'Class', # loc
value => sub { $_[0]->ClassObj->Name },
},
- CreatedRelative => {
- attribute => 'Created',
- title => 'Created', # loc
- value => sub { $_[0]->CreatedObj->AgeAsString },
- },
- LastUpdatedRelative => {
- attribute => 'LastUpdated',
- title => 'LastUpdated', # loc
- value => sub { $_[0]->LastUpdatedObj->AgeAsString },
- },
Topics => {
title => 'Topics', # loc
value => sub {
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list