[Rt-commit] rt branch, 4.2/remove-dbix-searchbuilder-unique, created. rt-4.1.5-242-gec94377

[Alex Vandiver]

The branch, 4.2/remove-dbix-searchbuilder-unique has been created
        at  ec943770781ecce3e83a46e6ddb4086c9e7282a6 (commit)

- Log -----------------------------------------------------------------
commit ec943770781ecce3e83a46e6ddb4086c9e7282a6
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Jan 7 19:06:38 2013 -0500

    Remove uses of ::Unique; our SELECT DISTINCT is sufficient
    
    Rather than import a mixin (twice, in Tickets' case (?!)) which
    unique-ifies the results, rely on our SELECT DISCINCT machinery.  The
    original code was added when DistinctQuery was unimplemented for some
    database handles.

diff --git a/lib/RT/CustomFields.pm b/lib/RT/CustomFields.pm
index a837f82..72c93aa 100644
--- a/lib/RT/CustomFields.pm
+++ b/lib/RT/CustomFields.pm
@@ -68,8 +68,6 @@ package RT::CustomFields;
 use strict;
 use warnings;
 
-use DBIx::SearchBuilder::Unique;
-
 use RT::CustomField;
 
 use base 'RT::SearchBuilder';
diff --git a/lib/RT/Tickets.pm b/lib/RT/Tickets.pm
index 2efa234..396ffc7 100644
--- a/lib/RT/Tickets.pm
+++ b/lib/RT/Tickets.pm
@@ -89,7 +89,6 @@ use base 'RT::SearchBuilder';
 sub Table { 'Tickets'}
 
 use RT::CustomFields;
-use DBIx::SearchBuilder::Unique;
 
 # Configuration Tables:
 
@@ -1939,16 +1938,6 @@ sub OrderByCols {
                QUOTEVALUE => 1,
                ENTRYAGGREGATOR => 'AND',
            ) if $CFs;
-           unless ($cf_obj) {
-               # For those cases where we are doing a join against the
-               # CF name, and don't have a CFid, use Unique to make sure
-               # we don't show duplicate tickets.  NOTE: I'm pretty sure
-               # this will stay mixed in for the life of the
-               # class/package, and not just for the life of the object.
-               # Potential performance issue.
-               require DBIx::SearchBuilder::Unique;
-               DBIx::SearchBuilder::Unique->import;
-           }
            my $CFvs = $self->Join(
                TYPE   => 'LEFT',
                ALIAS1 => $TicketCFs,

-----------------------------------------------------------------------