[Rt-commit] rt branch, 4.0-trunk, updated. rt-4.0.13-120-gee0712a

? sunnavy sunnavy at bestpractical.com
Fri Jul 5 17:09:23 EDT 2013


The branch, 4.0-trunk has been updated
       via  ee0712ae5cb0f9097ba2f68e97491589636f88c2 (commit)
      from  d59a3cd018f867446f60c88378476de04af8b516 (commit)

Summary of changes:
 share/html/Elements/Tabs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit ee0712ae5cb0f9097ba2f68e97491589636f88c2
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Sat Jul 6 04:15:31 2013 +0800

    order query parameters ourselves to avoid random ordering on perl-5.18+
    
    t/web/walk.t might test the same pages(only query params ordering differs) for
    multiple times without this.
    
    it's also more right if we show consistent urls.

diff --git a/share/html/Elements/Tabs b/share/html/Elements/Tabs
index addaeee..48fef90 100644
--- a/share/html/Elements/Tabs
+++ b/share/html/Elements/Tabs
@@ -55,7 +55,7 @@ $request_path =~ s!/{2,}!/!g;
 my $query_string = sub {
     my %args = @_;
     my $u    = URI->new();
-    $u->query_form(%args);
+    $u->query_form(map { $_ => $args{$_} } sort keys %args);
     return $u->query;
 };
 

-----------------------------------------------------------------------


More information about the Rt-commit mailing list