[Rt-commit] rt branch, 4.2/link-display, created. rt-4.1.13-283-g445d524
Alex Vandiver
alexmv at bestpractical.com
Tue Jul 9 15:32:23 EDT 2013
The branch, 4.2/link-display has been created
at 445d52481f19cbee36635811f2b73a3c118619cf (commit)
- Log -----------------------------------------------------------------
commit 445d52481f19cbee36635811f2b73a3c118619cf
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Tue Jul 9 15:31:52 2013 -0400
Avoid attempting to nest <a> tags with links and ShowUser
ShowUser now links to the user, which interacts poorly with beig inside
the Ma href="<% $href %>"> of the thing we are trying to link to.
diff --git a/share/html/Elements/ShowLink b/share/html/Elements/ShowLink
index 9593230..9f0ec15 100644
--- a/share/html/Elements/ShowLink
+++ b/share/html/Elements/ShowLink
@@ -45,20 +45,20 @@
%# those contributions and any derivatives thereof.
%#
%# END BPS TAGGED BLOCK }}}
-<a href="<% $href %>">
% my $member = $URI->Object;
% if (blessed($member) && $member->isa("RT::Ticket")) {
% my $inactive = $member->QueueObj->IsInactiveStatus($member->Status);
<span class="<% $inactive ? 'ticket-inactive' : '' %>">
-<%$member->Id%>: (<& /Elements/ShowUser, User => $member->OwnerObj &>) <%$member->Subject || ''%> [<% loc($member->Status) %>]
+<a href="<% $href %>"><%$member->Id%>:</a>
+(<& /Elements/ShowUser, User => $member->OwnerObj &>)
+<a href="<% $href %>"><%$member->Subject || ''%> [<% loc($member->Status) %>]</a>
</span>
% } else {
-<%$URI->AsString%>
+<a href="<% $href %>"><%$URI->AsString%></a>
% }
-</a>
<%ARGS>
$URI => undef
</%ARGS>
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list