[Rt-commit] rt branch, 4.2/link-display, repushed

Alex Vandiver alexmv at bestpractical.com
Tue Jul 9 16:32:17 EDT 2013


The branch 4.2/link-display was deleted and repushed:
       was 445d52481f19cbee36635811f2b73a3c118619cf
       now da32c52a877329038b030b5738a06ed831c87882

1:  445d524 ! 1:  da32c52 Avoid attempting to nest <a> tags with links and ShowUser
    @@ -3,7 +3,11 @@
         Avoid attempting to nest <a> tags with links and ShowUser
         
         ShowUser now links to the user, which interacts poorly with beig inside
    -    the Ma href="<% $href %>"> of the thing we are trying to link to.
    +    the <a href="<% $href %>"> of the thing we are trying to link to.
    +    
    +    Trailing "\" have been added such that Mason keeps the output on one
    +    line.  This is easier than fixing tests to look for results across one
    +    or two newlines but not across <span> elements.
     
     diff --git a/share/html/Elements/ShowLink b/share/html/Elements/ShowLink
     --- a/share/html/Elements/ShowLink
    @@ -20,8 +24,8 @@
      <span class="<% $inactive ? 'ticket-inactive' : '' %>">
      
     -<%$member->Id%>: (<& /Elements/ShowUser, User => $member->OwnerObj &>) <%$member->Subject || ''%> [<% loc($member->Status) %>]
    -+<a href="<% $href %>"><%$member->Id%>:</a>
    -+(<& /Elements/ShowUser, User => $member->OwnerObj &>)
    ++<a href="<% $href %>"><%$member->Id%>:</a> \
    ++(<& /Elements/ShowUser, User => $member->OwnerObj &>) \
     +<a href="<% $href %>"><%$member->Subject || ''%> [<% loc($member->Status) %>]</a>
      </span>
      



More information about the Rt-commit mailing list