[Rt-commit] rt branch, 4.2/remove-unused-templates-columns, created. rt-4.1.17-62-g295d8d7

Todd Wade todd at bestpractical.com
Mon Jul 22 12:59:00 EDT 2013


The branch, 4.2/remove-unused-templates-columns has been created
        at  295d8d7bb3840948a2fccef89ebe1a1d92818ddd (commit)

- Log -----------------------------------------------------------------
commit 295d8d7bb3840948a2fccef89ebe1a1d92818ddd
Author: Todd Wade <todd at bestpractical.com>
Date:   Mon Jul 22 12:58:12 2013 -0400

    Remove unused Language and TranslationOf columns on Templates
    
    see [issues#18720]

diff --git a/etc/schema.Oracle b/etc/schema.Oracle
index 4b992c7..35b81d9 100755
--- a/etc/schema.Oracle
+++ b/etc/schema.Oracle
@@ -314,8 +314,6 @@ CREATE TABLE Templates (
         Name            VARCHAR2(200) NOT NULL,
         Description     VARCHAR2(255),
         Type            VARCHAR2(16),
-        Language        VARCHAR2(16), 
-        TranslationOf   NUMBER(11,0) DEFAULT 0 NOT NULL,
         Content         CLOB,
         LastUpdated     DATE,
         LastUpdatedBy   NUMBER(11,0) DEFAULT 0 NOT NULL,
diff --git a/etc/schema.Pg b/etc/schema.Pg
index 6f07e89..fbb97b9 100755
--- a/etc/schema.Pg
+++ b/etc/schema.Pg
@@ -492,8 +492,6 @@ CREATE TABLE Templates (
   Name varchar(200) NOT NULL  ,
   Description varchar(255) NULL  ,
   Type varchar(16) NULL  ,
-  Language varchar(16) NULL  ,
-  TranslationOf integer NOT NULL DEFAULT 0  ,
   Content text NULL  ,
   LastUpdated TIMESTAMP NULL  ,
   LastUpdatedBy integer NOT NULL DEFAULT 0  ,
diff --git a/etc/schema.SQLite b/etc/schema.SQLite
index 967715e..b494dfe 100755
--- a/etc/schema.SQLite
+++ b/etc/schema.SQLite
@@ -345,8 +345,6 @@ CREATE TABLE Templates (
   Name varchar(200) collate NOCASE NOT NULL  ,
   Description varchar(255) collate NOCASE NULL  ,
   Type varchar(16) collate NOCASE NULL  ,
-  Language varchar(16) collate NOCASE NULL  ,
-  TranslationOf integer NULL DEFAULT 0 ,
   Content blob NULL  ,
   LastUpdated DATETIME NULL  ,
   LastUpdatedBy integer NULL DEFAULT 0 ,
diff --git a/etc/schema.mysql b/etc/schema.mysql
index 31b5316..bec3eec 100755
--- a/etc/schema.mysql
+++ b/etc/schema.mysql
@@ -326,8 +326,6 @@ CREATE TABLE Templates (
   Name varchar(200) NOT NULL  ,
   Description varchar(255) NULL  ,
   Type varchar(16) CHARACTER SET ascii NULL  ,
-  Language varchar(16) CHARACTER SET ascii NULL  ,
-  TranslationOf integer NOT NULL DEFAULT 0  ,
   Content TEXT NULL  ,
   LastUpdated DATETIME NULL  ,
   LastUpdatedBy integer NOT NULL DEFAULT 0  ,
diff --git a/etc/upgrade/4.1.19/schema.Oracle b/etc/upgrade/4.1.19/schema.Oracle
new file mode 100644
index 0000000..4e938e1
--- /dev/null
+++ b/etc/upgrade/4.1.19/schema.Oracle
@@ -0,0 +1,2 @@
+ALTER TABLE Templates DROP COLUMN Language;
+ALTER TABLE Templates DROP COLUMN TranslationOf;
diff --git a/etc/upgrade/4.1.19/schema.Pg b/etc/upgrade/4.1.19/schema.Pg
new file mode 100644
index 0000000..4e938e1
--- /dev/null
+++ b/etc/upgrade/4.1.19/schema.Pg
@@ -0,0 +1,2 @@
+ALTER TABLE Templates DROP COLUMN Language;
+ALTER TABLE Templates DROP COLUMN TranslationOf;
diff --git a/etc/upgrade/4.1.19/schema.mysql b/etc/upgrade/4.1.19/schema.mysql
new file mode 100644
index 0000000..4e938e1
--- /dev/null
+++ b/etc/upgrade/4.1.19/schema.mysql
@@ -0,0 +1,2 @@
+ALTER TABLE Templates DROP COLUMN Language;
+ALTER TABLE Templates DROP COLUMN TranslationOf;
diff --git a/lib/RT/Template.pm b/lib/RT/Template.pm
index 01c74d3..0210755 100644
--- a/lib/RT/Template.pm
+++ b/lib/RT/Template.pm
@@ -920,42 +920,6 @@ Returns (1, 'Status message') on success and (0, 'Error Message') on failure.
 =cut
 
 
-=head2 Language
-
-Returns the current value of Language.
-(In the database, Language is stored as varchar(16).)
-
-
-
-=head2 SetLanguage VALUE
-
-
-Set Language to VALUE.
-Returns (1, 'Status message') on success and (0, 'Error Message') on failure.
-(In the database, Language will be stored as a varchar(16).)
-
-
-=cut
-
-
-=head2 TranslationOf
-
-Returns the current value of TranslationOf.
-(In the database, TranslationOf is stored as int(11).)
-
-
-
-=head2 SetTranslationOf VALUE
-
-
-Set TranslationOf to VALUE.
-Returns (1, 'Status message') on success and (0, 'Error Message') on failure.
-(In the database, TranslationOf will be stored as a int(11).)
-
-
-=cut
-
-
 =head2 Content
 
 Returns the current value of Content.
@@ -1024,10 +988,6 @@ sub _CoreAccessible {
                 {read => 1, write => 1, sql_type => 12, length => 255,  is_blob => 0,  is_numeric => 0,  type => 'varchar(255)', default => ''},
         Type =>
                 {read => 1, write => 1, sql_type => 12, length => 16,  is_blob => 0,  is_numeric => 0,  type => 'varchar(16)', default => ''},
-        Language =>
-                {read => 1, write => 1, sql_type => 12, length => 16,  is_blob => 0,  is_numeric => 0,  type => 'varchar(16)', default => ''},
-        TranslationOf =>
-                {read => 1, write => 1, sql_type => 4, length => 11,  is_blob => 0,  is_numeric => 1,  type => 'int(11)', default => '0'},
         Content =>
                 {read => 1, write => 1, sql_type => -4, length => 0,  is_blob => 1,  is_numeric => 0,  type => 'text', default => ''},
         LastUpdated =>

-----------------------------------------------------------------------


More information about the Rt-commit mailing list