[Rt-commit] rt branch, 4.2/fixup-default-scrips, created. rt-4.1.8-557-g8cf495e

[Thomas Sibley]

The branch, 4.2/fixup-default-scrips has been created
        at  8cf495e243fea410675ee8b0fe8bfe1213c8665b (commit)

- Log -----------------------------------------------------------------
commit 264db7d8588af8c9774cc4ded53da8ab685bacf8
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu Mar 3 13:02:38 2011 -0500

    Make sure that On Create we notify Ccs and other recipients
    
    Otherwise the ticket create form is a partial lie.  I'm not sure how
    this wasn't noticed for so long.
    
    This probably also wants an upgrade step, but I'm not sure of the best
    way to do that at the moment.

diff --git a/etc/initialdata b/etc/initialdata
index 29b9163..f30edf7 100644
--- a/etc/initialdata
+++ b/etc/initialdata
@@ -722,6 +722,14 @@ Hour:         { $SubscriptionObj->SubValue('Hour') }
        ScripCondition => 'On Create',
        ScripAction    => 'Notify AdminCcs',
        Template       => 'Transaction in HTML' },
+    {  Description    => 'On Create Notify Ccs',
+       ScripCondition => 'On Create',
+       ScripAction    => 'Notify Ccs',
+       Template       => 'Correspondence in HTML' },
+    {  Description    => 'On Create Notify Other Recipients',
+       ScripCondition => 'On Create',
+       ScripAction    => 'Notify Other Recipients',
+       Template       => 'Correspondence in HTML' },
     {  Description    => 'On Owner Change Notify Owner',
        ScripCondition => 'On Owner Change',
        ScripAction    => 'Notify Owner',

commit e909ac3379d0349e063a7e0ccbff4733d4a58f94
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu Sep 27 11:12:40 2012 -0700

    Add a Notify Owner and AdminCcs action
    
    Combining notification of Owner and AdminCcs into the same action
    receives the benefit of duplicate recipient squashing if the Owner is
    (as commonly is the case) a queue-level AdminCc.

diff --git a/etc/initialdata b/etc/initialdata
index f30edf7..e2ae031 100644
--- a/etc/initialdata
+++ b/etc/initialdata
@@ -58,7 +58,10 @@
       Description => 'Sends mail to the administrative Ccs',              # loc
       ExecModule  => 'Notify',
       Argument    => 'AdminCc' },
-
+    { Name        => 'Notify Owner and AdminCcs',                         # loc
+      Description => 'Sends mail to the Owner and administrative Ccs',    # loc
+      ExecModule  => 'Notify',
+      Argument    => 'Owner,AdminCc' },
     { Name        => 'Notify Requestors and Ccs as Comment',              # loc
       Description => 'Send mail to requestors and Ccs as a comment',      # loc
       ExecModule  => 'NotifyAsComment',

commit 9fcdd1bda3f376a54521b57384e14277a2a65542
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu Sep 27 11:18:17 2012 -0700

    Notify Owner too on Create and Correspond, not just AdminCcs
    
    Otherwise Owners who aren't a queue AdminCc (or also a ticket level
    AdminCc) don't receive mail!
    
    This needs a smart upgrade path, similar to 63852e9, which adds the
    action if it doesn't exist already and modifies the default scrips if
    they still exist.  It also needs a note in UPGRADING-4.2.

diff --git a/etc/initialdata b/etc/initialdata
index e2ae031..bbccab5 100644
--- a/etc/initialdata
+++ b/etc/initialdata
@@ -701,9 +701,9 @@ Hour:         { $SubscriptionObj->SubValue('Hour') }
        ScripCondition => 'On Comment',
        ScripAction    => 'Notify Other Recipients As Comment',
        Template       => 'Correspondence in HTML' },
-    {  Description    => 'On Correspond Notify AdminCcs',
+    {  Description    => 'On Correspond Notify Owner and AdminCcs',
        ScripCondition => 'On Correspond',
-       ScripAction    => 'Notify AdminCcs',
+       ScripAction    => 'Notify Owner and AdminCcs',
        Template       => 'Admin Correspondence in HTML' },
     {  Description    => 'On Correspond Notify Other Recipients',
        ScripCondition => 'On Correspond',
@@ -721,9 +721,9 @@ Hour:         { $SubscriptionObj->SubValue('Hour') }
        ScripCondition => 'On Create',
        ScripAction    => 'AutoReply To Requestors',
        Template       => 'AutoReply in HTML' },
-    {  Description    => 'On Create Notify AdminCcs',
+    {  Description    => 'On Create Notify Owner and AdminCcs',
        ScripCondition => 'On Create',
-       ScripAction    => 'Notify AdminCcs',
+       ScripAction    => 'Notify Owner and AdminCcs',
        Template       => 'Transaction in HTML' },
     {  Description    => 'On Create Notify Ccs',
        ScripCondition => 'On Create',

commit 8cf495e243fea410675ee8b0fe8bfe1213c8665b
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu Jun 6 13:39:20 2013 -0700

    Add the new action "Notify Owner and AdminCcs" on upgrade
    
    Rather than try to automatically upgrade scrips, make a note of the
    changes and let admins manually update if they'd like.

diff --git a/docs/UPGRADING-4.2 b/docs/UPGRADING-4.2
index 2a5bc12..f17463f 100644
--- a/docs/UPGRADING-4.2
+++ b/docs/UPGRADING-4.2
@@ -129,3 +129,7 @@ UPGRADING FROM RT 4.0.0 and greater
   and granting Everyone the OwnTicket right is a common cause of
   performance problems.  Unprivileged Owners (if they exist) may still
   be set using the Autocompleter.
+
+* New installs will notify Ccs and one-time Ccs/Bccs on create and Owners on
+  create and correspond.  Upgraded installations will not.  If you'd like to
+  adjust your scrips, the actions are available from the admin scrip pages.
diff --git a/etc/upgrade/4.1.15/content b/etc/upgrade/4.1.15/content
new file mode 100644
index 0000000..c1d8a61
--- /dev/null
+++ b/etc/upgrade/4.1.15/content
@@ -0,0 +1,9 @@
+use strict;
+use warnings;
+
+our @ScripActions = (
+    { Name        => 'Notify Owner and AdminCcs',                         # loc
+      Description => 'Sends mail to the Owner and administrative Ccs',    # loc
+      ExecModule  => 'Notify',
+      Argument    => 'Owner,AdminCc' },
+);

-----------------------------------------------------------------------