[Rt-commit] rt branch, 4.0/add-with-disabled-column, created. rt-4.0.13-53-gec4267f
Todd Wade
todd at bestpractical.com
Mon Jun 10 13:36:40 EDT 2013
The branch, 4.0/add-with-disabled-column has been created
at ec4267f2ff67044b222d361e632305a9b44b980c (commit)
- Log -----------------------------------------------------------------
commit ec4267f2ff67044b222d361e632305a9b44b980c
Author: Todd Wade <todd at bestpractical.com>
Date: Wed Jun 5 10:10:34 2013 -0400
set with_disabled_column in classes where it is missing
Set with_disabled_column in classes that have a disabled column in
the database but the flag is missing in the collection class.
The following classes will NOT get with_disabled_column set even
though the corresponding database table has a disabled column:
RT::Tickets
- Will be dealt with in 4.2 by dropping the column
RT::CachedGroupMembers
- all use cases of this lib need reviewed before adding
RT::ObjectCustomFieldValues
- Will be dealt with in 4.2 by renaming the flag.
See issues:20766
diff --git a/lib/RT/Classes.pm b/lib/RT/Classes.pm
index 60122c7..8949d9b 100644
--- a/lib/RT/Classes.pm
+++ b/lib/RT/Classes.pm
@@ -54,6 +54,15 @@ use base 'RT::SearchBuilder';
sub Table {'Classes'}
+=head2 _Init
+
+=cut
+
+ sub _Init {
+ my $self = shift;
+ $self->{'with_disabled_column'} = 1;
+ return ($self->SUPER::_Init(@_));
+ }
=head2 Next
diff --git a/lib/RT/Principals.pm b/lib/RT/Principals.pm
index 9cf8cbb..d0a939a 100644
--- a/lib/RT/Principals.pm
+++ b/lib/RT/Principals.pm
@@ -78,6 +78,7 @@ sub Table { 'Principals'}
sub _Init {
my $self = shift;
+ $self->{'with_disabled_column'} = 1;
return ( $self->SUPER::_Init(@_) );
}
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list