[Rt-commit] rt branch, 4.2/cf-page-menu-in-queue-admin, created. rt-4.1.8-573-g75ae14f

Ruslan Zakirov ruz at bestpractical.com
Thu Jun 13 15:33:35 EDT 2013


The branch, 4.2/cf-page-menu-in-queue-admin has been created
        at  75ae14fb0fcb13d076c639750ee91f2a63327678 (commit)

- Log -----------------------------------------------------------------
commit 75ae14fb0fcb13d076c639750ee91f2a63327678
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Thu Jun 13 17:12:14 2013 +0400

    CF tabs in Queues' admin interface
    
    Put "Ticket Custom Fields" and "Transaction Custom Fields" page
    tabs under one "Custom Fields" tab. Page tabs were just two wide,
    so in some translations it could quickly become two line instead
    of usual one and hide content.
    
    Top "Custom Fields" tab is not linked as I feel that for a queue
    it should link to a list of queue's custom fields, but we don't
    have such page as these custom fields are global. Linking to
    Global -> Custom Fields -> Queues is an option, but I decided
    not to go there.

diff --git a/share/html/Elements/Tabs b/share/html/Elements/Tabs
index 9595c65..1205819 100644
--- a/share/html/Elements/Tabs
+++ b/share/html/Elements/Tabs
@@ -297,10 +297,11 @@ my $build_admin_menu = sub {
                 $scrips->child( select => title => loc('Select'), path => "/Admin/Queues/Scrips.html?id=" . $id );
                 $scrips->child( create => title => loc('Create'), path => "/Admin/Scrips/Create.html?Queue=" . $id);
 
-                my $ticket_cfs = $queue->child( 'ticket-custom-fields' => title => loc('Ticket Custom Fields'),
+                my $cfs = $queue->child( 'custom-fields' => title => loc('Custom Fields') );
+                my $ticket_cfs = $cfs->child( 'tickets' => title => loc('Tickets'),
                     path => '/Admin/Queues/CustomFields.html?SubType=RT::Ticket&id=' . $id );
 
-                my $txn_cfs = $queue->child( 'transaction-custom-fields' => title => loc('Transaction Custom Fields'),
+                my $txn_cfs = $cfs->child( 'transactions' => title => loc('Transactions'),
                     path => '/Admin/Queues/CustomFields.html?SubType=RT::Ticket-RT::Transaction&id='.$id );
 
                 $queue->child( 'group-rights' => title => loc('Group Rights'), path => "/Admin/Queues/GroupRights.html?id=".$id );

-----------------------------------------------------------------------


More information about the Rt-commit mailing list