[Rt-commit] rt branch, 4.2/user-summary-css, created. rt-4.1.13-19-ge708350

Alex Vandiver alexmv at bestpractical.com
Tue Jun 18 00:37:12 EDT 2013


The branch, 4.2/user-summary-css has been created
        at  e7083509e5bdaf40e98a06d734e8abb383be45cc (commit)

- Log -----------------------------------------------------------------
commit 4d8b5eec3c6afafd43e0e4406ccf362f6e00b832
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Jun 17 17:53:30 2013 -0400

    Allow CSS classes on user ticketlists

diff --git a/share/html/User/Elements/TicketList b/share/html/User/Elements/TicketList
index 33cb60d..9f90c88 100644
--- a/share/html/User/Elements/TicketList
+++ b/share/html/User/Elements/TicketList
@@ -46,7 +46,7 @@
 %#
 %# END BPS TAGGED BLOCK }}}
 % if ( $TitleBox ) {
-    <& /Widgets/TitleBoxStart, title => $Title, title_href => $url, &>
+    <& /Widgets/TitleBoxStart, title => $Title, title_href => $url, class => $Class &>
 % } else {
     <span class="label"><a href="<% $url %>"><% $Title %>:</a></span>
 % }
@@ -103,6 +103,7 @@ $m->callback( CallbackName => 'ModifyQueryProperties',
 </%INIT>
 <%ARGS>
 $Title => ''
+$Class => ''
 @WatcherTypes => (qw(Watcher))
 $User => undef
 $conditions

commit b7acd6111e97ce4d9f36b84f4f777aabe228f998
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Jun 17 17:53:56 2013 -0400

    Add CSS classes to the two existing user ticketlists

diff --git a/share/html/User/Elements/Portlets/ActiveTickets b/share/html/User/Elements/Portlets/ActiveTickets
index 35e9a0f..d76a2b5 100644
--- a/share/html/User/Elements/Portlets/ActiveTickets
+++ b/share/html/User/Elements/Portlets/ActiveTickets
@@ -50,6 +50,7 @@
     conditions => $conditions,
     Rows => $Rows,
     WatcherTypes => [qw(Watcher)],
+    Class => "user active-tickets",
     Title => loc('Active Tickets'),
     TitleBox => 1,
     ShowHeader => 1,
diff --git a/share/html/User/Elements/Portlets/InactiveTickets b/share/html/User/Elements/Portlets/InactiveTickets
index 0c4e8d2..a7ad953 100644
--- a/share/html/User/Elements/Portlets/InactiveTickets
+++ b/share/html/User/Elements/Portlets/InactiveTickets
@@ -50,6 +50,7 @@
     conditions => $conditions,
     Rows => $Rows,
     WatcherTypes => [qw(Watcher)],
+    Class => "user active-tickets",
     Title => loc('Inactive Tickets'),
     TitleBox => 1,
     ShowHeader => 1,

commit fa25a7283351980f5da579f4db31d79be7ca449d
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Jun 17 17:55:47 2013 -0400

    Move CSS classes to the titlebox, and standardize them to their component names

diff --git a/share/html/User/Elements/Portlets/CreateTicket b/share/html/User/Elements/Portlets/CreateTicket
index a790672..454796c 100644
--- a/share/html/User/Elements/Portlets/CreateTicket
+++ b/share/html/User/Elements/Portlets/CreateTicket
@@ -45,8 +45,7 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<div class="quick-create user">
-<&| /Widgets/TitleBox, title => loc('Quick ticket creation') &>
+<&| /Widgets/TitleBox, title => loc('Quick ticket creation'), class => "user create-ticket" &>
 <form action="<%RT->Config->Get('WebPath')%>/Ticket/Create.html">
 <&|/l&>Create a ticket with this user as the Requestor in Queue</&>
 <input type="hidden" name="Requestors" value="<%$User->EmailAddress%>">
@@ -54,7 +53,6 @@
 <input type="submit" name="Create">
 </form>
 </&>
-</div>
 <%ARGS>
 $User
 </%ARGS>
diff --git a/share/html/User/Elements/Portlets/ExtraInfo b/share/html/User/Elements/Portlets/ExtraInfo
index 1578005..757d1ed 100644
--- a/share/html/User/Elements/Portlets/ExtraInfo
+++ b/share/html/User/Elements/Portlets/ExtraInfo
@@ -45,13 +45,11 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<&| /Widgets/TitleBox, title => loc('User Information') &>
-<div class="details">
+<&| /Widgets/TitleBox, title => loc('User Information'), class => "user extra-info" &>
 
 % $m->callback( User => $User, CallbackName => 'BeforeExtraInfo' );
 <& /User/Elements/UserInfo, User => $User, FormatConfig => 'UserSummaryExtraInfo', ClassPrefix => 'user-summary' &>
 
-</div>
 </&>
 <%ARGS>
 $User

commit e7083509e5bdaf40e98a06d734e8abb383be45cc
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Jun 17 17:57:14 2013 -0400

    Use value= to change the label; name="Create" with no value has no effect

diff --git a/share/html/User/Elements/Portlets/CreateTicket b/share/html/User/Elements/Portlets/CreateTicket
index 454796c..d906d88 100644
--- a/share/html/User/Elements/Portlets/CreateTicket
+++ b/share/html/User/Elements/Portlets/CreateTicket
@@ -50,7 +50,7 @@
 <&|/l&>Create a ticket with this user as the Requestor in Queue</&>
 <input type="hidden" name="Requestors" value="<%$User->EmailAddress%>">
 <& /Elements/SelectNewTicketQueue &>
-<input type="submit" name="Create">
+<input type="submit" value="Create">
 </form>
 </&>
 <%ARGS>

-----------------------------------------------------------------------


More information about the Rt-commit mailing list