[Rt-commit] [rtir] 03/03: Display default Incidents as selected
Kevin Falcone
falcone at bestpractical.com
Fri Jun 21 17:54:00 EDT 2013
This is an automated email from the git hooks/post-receive script.
falcone pushed a commit to branch 2.9/split-multiple-incidents
in repository rtir.
commit 17ff8b79e8280f7d548ee68daa62195802df0f48
Author: Kevin Falcone <falcone at bestpractical.com>
Date: Fri Jun 21 17:39:44 2013 -0400
Display default Incidents as selected
The core ColumnMap entries used by RadioButton or Checkbox types (such
as the ones used in SelectIncident) grovel in DECODED_ARGS to figure out
what to select. I'm not thrilled with jamming things into DECODED_ARGS
but there are a few parts of core that do it, and there isn't another
API to set selected status in ColumnMap from a distance.
Without this change, when Splitting a Report or Block, SelectIncident
will show the Incident(s) parent(s) without selecting anything, so
you're likely to forget to go check the boxes.
---
html/RTIR/Create.html | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/html/RTIR/Create.html b/html/RTIR/Create.html
index 8d65292..f1505d4 100644
--- a/html/RTIR/Create.html
+++ b/html/RTIR/Create.html
@@ -363,8 +363,10 @@ if ( $Split ) {
$SplitObj = LoadTicket( $Split );
$ARGS{'Split'} = $Split = $SplitObj->id;
- @Incident = map $_->id, @{ RT::IR->Incidents( $SplitObj )->ItemsArrayRef || [] }
- unless @Incident;
+ unless (@Incident) {
+ @Incident = map $_->id, @{ RT::IR->Incidents( $SplitObj )->ItemsArrayRef || [] };
+ $DECODED_ARGS->{Incident} = \@Incident;
+ }
}
my @IncidentObj;
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the Rt-commit
mailing list