[Rt-commit] [rtir] 01/01: Simplify Signature Inclusion

Kevin Falcone falcone at bestpractical.com
Mon Jun 24 18:23:15 EDT 2013


This is an automated email from the git hooks/post-receive script.

falcone pushed a commit to branch 3.0/consistent-signature
in repository rtir.

commit 772ca23266ca6d1dab27fa57ff7b3e138c6cfe65
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Mon Jun 24 18:11:56 2013 -0400

    Simplify Signature Inclusion
    
    Now that Incidents have been hardcoded not to include signatures
    (0efa2a4) because they're intended for internal consumption, remove this
    variable.  Investigations are a simple "do I have content?  If not,
    include a signature" check, similar to how RT's normal Ticket signatures
    work.
---
 html/RTIR/Incident/Create.html | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/html/RTIR/Incident/Create.html b/html/RTIR/Incident/Create.html
index caeb32d..123a7b9 100644
--- a/html/RTIR/Incident/Create.html
+++ b/html/RTIR/Incident/Create.html
@@ -243,7 +243,7 @@ if ( $ChildObj && !$ChildObj->CurrentUserHasRight('ModifyTicket') ) {
     NamePrefix => 'Investigation',
     Queue => 'Investigations',
     SkipField => { Owner => 1, Attachments => 1, DateFields => 1 },
-    IncludeSignature => $include_signature,
+    IncludeSignature => (exists $ARGS{'InvestigationContent'} ? 0 : 1),
 &>
 <& /Elements/Submit,
     Name => 'CreateWithInvestigation',
@@ -425,7 +425,6 @@ PageMenu->child(
     . q[>] . loc('Launch Investigation') . q[</a>]
 );
 
-my $include_signature = 1;
 unless ( exists $ARGS{'Content'} ) {
     my $Transactions;
     if ( $SplitObj ) {
@@ -441,8 +440,6 @@ unless ( exists $ARGS{'Content'} ) {
         ) || '';
         $ARGS{'Content'} =~ s/\>/>/g;
     }
-} else {
-    $include_signature = 0;
 }
 </%INIT>
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Rt-commit mailing list