[Rt-commit] rt branch, master, updated. rt-4.1.6-346-g2b50fd0

Kevin Falcone falcone at bestpractical.com
Thu Mar 14 20:13:29 EDT 2013


The branch, master has been updated
       via  2b50fd0f34bf18f5f76b149ab23a27bda69b2794 (commit)
       via  79da81d92b9e29c63375f4d061e07879ca044b6b (commit)
      from  2228ce7277d469ad056ba0ae21930dafa5be4551 (commit)

Summary of changes:
 sbin/rt-test-dependencies.in | 2 +-
 share/html/Elements/MyRT     | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit 79da81d92b9e29c63375f4d061e07879ca044b6b
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Wed Mar 13 15:56:16 2013 -0400

    We totally use this
    
    We check to see if the component we're rendering is in
    HomepageComponents, and if it isn't we show an 'invalid portlet'
    message.
    
    When this comment was added in 6c33588 we really weren't using
    allowed_components, but when we started using it in 890312ab the comment
    wasn't removed.

diff --git a/share/html/Elements/MyRT b/share/html/Elements/MyRT
index 0c9f34c..e989cdf 100644
--- a/share/html/Elements/MyRT
+++ b/share/html/Elements/MyRT
@@ -63,7 +63,6 @@
 % $m->callback( ARGSRef => \%ARGS, CallbackName => 'AfterTable' );
 <%INIT>
 
-# XXX: we don't use this, but should.
 my %allowed_components = map {$_ => 1} @{RT->Config->Get('HomepageComponents')};
 
 my $user = $session{'CurrentUser'}->UserObj;

commit 2b50fd0f34bf18f5f76b149ab23a27bda69b2794
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Wed Mar 13 15:11:30 2013 -0700

    Require Symbol::Global::Name 0.02 so the names of references are found
    
    Fixed on 4.0-trunk as 3cb2f29.  Resolves [rt3 #16951] for master.

diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index 1498d55..a48fb71 100644
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -229,7 +229,7 @@ Regexp::IPv6
 Role::Basic 0.12
 Scalar::Util
 Storable 2.08
-Symbol::Global::Name
+Symbol::Global::Name 0.02
 Sys::Syslog 0.16
 Text::Password::Pronounceable
 Text::Quoted 2.02

-----------------------------------------------------------------------


More information about the Rt-commit mailing list