[Rt-commit] rt branch, 4.2/init-log-in-setup-database-earlier, created. rt-4.1.8-262-g33eaf08

[Ruslan Zakirov]

The branch, 4.2/init-log-in-setup-database-earlier has been created
        at  33eaf0812baad68e4e59a27e4c35a97876f0a7cd (commit)

- Log -----------------------------------------------------------------
commit 33eaf0812baad68e4e59a27e4c35a97876f0a7cd
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Thu May 9 03:09:36 2013 +0400

    no obvious reasons to delay log initialization
    
    It even can hurt upgrade as permissions on LogToFile file
    can abort upgrade in the middle.

diff --git a/sbin/rt-setup-database.in b/sbin/rt-setup-database.in
index 910bfe9..dc2161d 100644
--- a/sbin/rt-setup-database.in
+++ b/sbin/rt-setup-database.in
@@ -100,6 +100,7 @@ RT->InitClasses();
 RT->Config->Set( LogToScreen => 'warning')
     unless ( RT->Config->Get( 'LogToScreen' )
              && RT->Config->Get( 'LogToScreen' ) =~ /^(debug|info|notice)$/ );
+RT::InitLogging();
 
 # get customized root password
 my $root_password;
@@ -248,7 +249,6 @@ sub action_coredata {
     $RT::Handle = RT::Handle->new;
     $RT::Handle->dbh( undef );
     RT::ConnectToDatabase();
-    RT::InitLogging();
     my ($status, $msg) = RT::Handle->CheckCompatibility( $RT::Handle->dbh, 'coredata' );
     return ($status, $msg) unless $status;
 
@@ -404,7 +404,6 @@ sub action_upgrade {
     _yesno() or exit(-2) unless $args{'force'};
 
     RT->ConnectToDatabase();
-    RT->InitLogging();
     RT->InitSystemObjects();
 
     RT->System->AddUpgradeHistory($package => {

-----------------------------------------------------------------------