[Rt-commit] rt branch, 4.2/fix-check-all-clear-all-buttons, created. rt-4.1.8-268-g64e3553
Ruslan Zakirov
ruz at bestpractical.com
Fri May 10 17:16:21 EDT 2013
The branch, 4.2/fix-check-all-clear-all-buttons has been created
at 64e35533b0b1b029bc3ec9f1631a16f11a2e1681 (commit)
- Log -----------------------------------------------------------------
commit 64e35533b0b1b029bc3ec9f1631a16f11a2e1681
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date: Sat May 11 01:13:27 2013 +0400
fix CheckAll/ClearAll buttons next to Submit
third argument should be explicit as buttons are not checkboxes,
so `this` that is passed as first argument has .checked equal to
false, so both buttons act as clear all
diff --git a/share/html/Elements/Submit b/share/html/Elements/Submit
index 0e61b9a..a5921ba 100644
--- a/share/html/Elements/Submit
+++ b/share/html/Elements/Submit
@@ -52,10 +52,10 @@ id="<%$id%>"
>
<div class="extra-buttons">
% if ($CheckAll) {
- <input type="button" value="<%$CheckAllLabel%>" onclick="setCheckbox(this, <% $match %>);return false;" class="button" />
+ <input type="button" value="<%$CheckAllLabel%>" onclick="setCheckbox(this, <% $match %>, true);return false;" class="button" />
% }
% if ($ClearAll) {
- <input type="button" value="<%$ClearAllLabel%>" onclick="setCheckbox(this, <% $match %>);return false;" class="button" />
+ <input type="button" value="<%$ClearAllLabel%>" onclick="setCheckbox(this, <% $match %>, false);return false;" class="button" />
% }
% if ($Reset) {
<input type="reset" value="<%$ResetLabel%>" class="button" />
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list