[Rt-commit] rt branch, 4.2/remove-resolved-modifier, created. rt-4.1.8-303-g07c9d74

Todd Wade todd at bestpractical.com
Thu May 16 16:47:41 EDT 2013


The branch, 4.2/remove-resolved-modifier has been created
        at  07c9d740c5c96ed85d9a1f2f9805f23f61ffd1a1 (commit)

- Log -----------------------------------------------------------------
commit 07c9d740c5c96ed85d9a1f2f9805f23f61ffd1a1
Author: Todd Wade <todd at bestpractical.com>
Date:   Tue May 14 14:14:54 2013 -0400

    remove ability to update resolved date
    
    The bulk updater lets you set the resolved date, but its generally
    assumed that the only reason this is set is because the ticket has
    been resolved at some point. This commit removes the bulk updater's
    ability to set resolved date.
    
    see issues#20302

diff --git a/lib/RT/Interface/Web.pm b/lib/RT/Interface/Web.pm
index c64f70a..9a4dedb 100644
--- a/lib/RT/Interface/Web.pm
+++ b/lib/RT/Interface/Web.pm
@@ -3288,7 +3288,6 @@ sub ProcessTicketDates {
     # Set date fields
     my @date_fields = qw(
         Told
-        Resolved
         Starts
         Started
         Due
diff --git a/share/html/Search/Bulk.html b/share/html/Search/Bulk.html
index e361550..e868b53 100644
--- a/share/html/Search/Bulk.html
+++ b/share/html/Search/Bulk.html
@@ -114,8 +114,6 @@
 <td class="value"> <& /Elements/SelectDate, Name => "Told_Date", Default => $ARGS{Told_Date} || '' &> </td></tr>
 <tr><td class="label"> <&|/l&>Make date Due</&>: </td>
 <td class="value"> <& /Elements/SelectDate, Name => "Due_Date", Default => $ARGS{Due_Date} || '' &> </td></tr>
-<tr><td class="label"> <&|/l&>Make date Resolved</&>: </td>
-<td class="value"> <& /Elements/SelectDate, Name => "Resolved_Date", Default => $ARGS{Resolved_Date} || '' &> </td></tr>
 </table>
 
 </td>
diff --git a/t/web/search_bulk_update_links.t b/t/web/search_bulk_update_links.t
index ffe2efe..d9b477e 100644
--- a/t/web/search_bulk_update_links.t
+++ b/t/web/search_bulk_update_links.t
@@ -1,7 +1,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 47;
+use RT::Test tests => 46;
 my ( $url, $m ) = RT::Test->started_ok;
 ok( $m->login, 'logged in' );
 
@@ -79,7 +79,7 @@ $m->content_lacks( 'DeleteLink--', 'no delete link stuff' );
 $m->form_name('BulkUpdate');
 my @fields = qw/Owner AddRequestor DeleteRequestor AddCc DeleteCc AddAdminCc
 DeleteAdminCc Subject Priority Queue Status Starts_Date Told_Date Due_Date
-Resolved_Date UpdateSubject UpdateContent/;
+UpdateSubject UpdateContent/;
 for my $field ( @fields ) {
     is( $m->value($field), '', "default $field is empty" );
 }

-----------------------------------------------------------------------


More information about the Rt-commit mailing list