[Rt-commit] rt branch, master, updated. rt-4.1.8-395-ge934abb

Wed May 22 15:31:39 EDT 2013

The branch, master has been updated
       via  e934abb533bdb4523743900e8238e4c904d290ab (commit)
       via  9fc111adc9e9fdbbf11bb7a0d4933d15344c7efb (commit)
       via  e48b94252c0bb4ab55587515cf695c0300b72d03 (commit)
       via  3056568f2fb6cbb84fbb2cf33a1e973d72f87893 (commit)
       via  dad34f3b62ecea49f6cc434778f2970c2b56e7d2 (commit)
      from  c91e9e554c812c73fee2757c8fdcac2a20a022c9 (commit)

Summary of changes:
 docs/UPGRADING-4.2                      |  7 +++++++
 etc/RT_Config.pm.in                     |  6 ++++++
 share/html/Elements/SelectOwnerDropdown | 27 ++++++++++++++++++++-------
 3 files changed, 33 insertions(+), 7 deletions(-)

- Log -----------------------------------------------------------------
commit e934abb533bdb4523743900e8238e4c904d290ab
Merge: c91e9e5 9fc111a
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed May 22 15:19:56 2013 -0400

    Merge branch '4.2/owner-display'
    
    Conflicts:
    	docs/UPGRADING-4.2
    	share/html/Elements/SelectOwnerDropdown

diff --cc docs/UPGRADING-4.2
index 8140102,81723c4..2a5bc12

--- a/docs/UPGRADING-4.2
+++ b/docs/UPGRADING-4.2
@@@ -77,48 -77,9 +77,55 @@@ UPGRADING FROM RT 4.0.0 and greate
    Googleish_Local.pm to add features, you will need to convert to
    using RT::Search::Simple instead.
  
 +* RT was recording additional time change transactions during merge, so
 +  difference in ticket's history doesn't add up value on ticket. This has
 +  been fixed, time is adjusted during merge, but now transactions are recorded.
 +
 +  In order to fix history records of old ticket you can run the following
 +  command:
 +
 +    perl -I /opt/rt4/local/lib/ -I /opt/rt4/lib/ etc/upgrade/time-worked-history.pl
 +
 +  This command deletes records from Transactions table. This script can only fix
 +  TimeWorked mismatch, but not TimeLeft or TimeEstimated.
 +
 +* A new action, "Open Inactive Tickets", has been added, and on new
 +  installs the default scrip "On Correspond Open Tickets" has been
 +  replaced by "On Correspond Open Inactive Tickets".  The key difference
 +  between "Open Tickets" and "Open Inactive Tickets" is that the latter
 +  will not adjust the status of a ticket if it is already active.  This
 +  is particularly useful when creating complex workflows using
 +  Lifecycles.
 +
 +* CSS is no longer processed through Mason; it's served by a proper static file
 +  handler.  If you used the Begin or End callbacks of main.css in the aileron,
 +  web2, or ballard themes, you should transition to the @CSSFiles config option.
 +  If you need to target specific themes, you can use the class set on the <body>
 +  element (for example: body.aileron).  See docs/customizing/styling_rt.pd for
 +  more information on custom styles.
 +
 +* There are now HTML versions of the standard plain text templates.  Running
 +  make upgrade as described in the README will insert the new templates into
 +  existing installs.  While new installs use the HTML templates by default,
 +  upgrades from older versions don't automatically switch to the HTML versions.
 +  To switch existing scrips, run:
 +
 +    /opt/rt4/etc/upgrade/switch-templates-to html
 +
 +  To switch from HTML back to text, run:
 +
 +    /opt/rtr/etc/upgrade/switch-templates-to text
 +
 +* The Articles menu is now a top-level menu item and display is controlled by
 +  the right ShowArticlesMenu.  This right is only grantable globally to groups
 +  or users.  During the upgrade, the new right will be automatically granted to
 +  Privileged users so that the menu doesn't disappear for anyone previously
 +  using it.  You may wish to revoke the right from Privileged and grant it
 +  more selectively.
++
+ * The Owner drop-down now only includes privileged users (no matter if
+   unprivileged users have been granted the OwnTicket right) because
+   configurations which have unprivileged Owners are exceedingly rare,
+   and granting Everyone the OwnTicket right is a common cause of
+   performance problems.  Unprivileged Owners (if they exist) may still
+   be set using the Autocompleter.
diff --cc share/html/Elements/SelectOwnerDropdown
index a291aee,4f3db02..f9bbcaa
--- a/share/html/Elements/SelectOwnerDropdown
+++ b/share/html/Elements/SelectOwnerDropdown
@@@ -87,8 -90,16 +90,18 @@@ if ($Default && $Default != RT->Nobody-
      $user_uniq_hash{$Default} = RT::User->new($session{CurrentUser});
      $user_uniq_hash{$Default}->Load($Default);
  }
+ $Default = 0 unless defined $Default && $Default =~ /^\d+$/;
+ 
+ my @formatednames = sort {lc $a->[1] cmp lc $b->[1]}
+                      map {[$_, $_->Format]}
+                     grep { $_->id != RT->Nobody->id }
+                   values %user_uniq_hash;
+ 
 -unshift @formatednames,
 -    [RT->Nobody, RT->Nobody->Format(CurrentUser => $session{CurrentUser})];
++my $nobody_user = RT::User->new( $session{CurrentUser} );
++$nobody_user->Load( RT->Nobody->id );
++my $nobody = [$nobody_user, $nobody_user->Format];
++unshift @formatednames, $nobody;
  
- my @users = values %user_uniq_hash;
  </%INIT>
  
  <%ARGS>

-----------------------------------------------------------------------
