[Rt-commit] rt branch, 4.2/oracle-fixes, created. rt-4.2.0-139-gfd66493

[Alex Vandiver]

The branch, 4.2/oracle-fixes has been created
        at  fd66493495acde6a321fd3e560a01002284a198b (commit)

- Log -----------------------------------------------------------------
commit e50dedde9e2ac8118f5a08f8412895ba415922a2
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Tue Nov 12 19:01:28 2013 -0500

    Update MaxAttachmentSize option to document its other use
    
    This dual-meaning of MaxAttachmentSize was introduced in eeb5a70, in
    3.0.10.

diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
index 5ec562c..22d6ddf 100755
--- a/etc/RT_Config.pm.in
+++ b/etc/RT_Config.pm.in
@@ -370,11 +370,14 @@ Set($StoreLoops, undef);
 
 C<$MaxAttachmentSize> sets the maximum size (in bytes) of attachments
 stored in the database.  This setting is irrelevant unless one of
-$TruncateLongAttachments or $DropLongAttachments (below) are set.
+$TruncateLongAttachments or $DropLongAttachments (below) are set, B<OR>
+the database is stored in Oracle.  On Oracle, attachments larger than
+this can be fully stored, but will be truncated to this length when
+read.
 
 =cut
 
-Set($MaxAttachmentSize, 10_000_000);
+Set($MaxAttachmentSize, 10_000_000);  # 10M
 
 =item C<$TruncateLongAttachments>
 

commit fd66493495acde6a321fd3e560a01002284a198b
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Tue Nov 12 19:07:29 2013 -0500

    Increase maximum session size to match maximum attachment size
    
    Apache::Session::Oracle defaults the maximum session size to 8k, using
    LongReadLen; this is insufficient for many RT sessions.  Increase the
    size of Apache::Session::Oracle's LongReadLen to match LongReadLen as it
    is defined in core RT -- as $MaxAttachmentSize.

diff --git a/lib/RT/Interface/Web/Session.pm b/lib/RT/Interface/Web/Session.pm
index f2dd603..ee685ac 100644
--- a/lib/RT/Interface/Web/Session.pm
+++ b/lib/RT/Interface/Web/Session.pm
@@ -131,6 +131,8 @@ sub Attributes {
             Transaction => 1,
         };
     }
+    $res->{LongReadLen} = RT->Config->Get('MaxAttachmentSize')
+        if $class->isa('Apache::Session::Oracle');
     return $res;
 }
 

-----------------------------------------------------------------------