[Rt-commit] rt branch, 4.0/preserve-ticket-basics, repushed

[Alex Vandiver]

The branch 4.0/preserve-ticket-basics was deleted and repushed:
       was 42d12d11c58812d736c2e745168adaa5fdf4c4b3
       now 6dae9cdcc9263e1baa8f5037e3d66668008bcf0a

 1:  1fdf48a < --:  ------- Add tests to check that time units are preserved across form submits
 2:  dc46701 < --:  ------- Preserve time units chosen across submits on the ticket-create form
 3:  b858992 < --:  ------- Add tests for checking time units across submits for ticket updates
--:  ------- >  1:  d7ed467 Preerve time units (checkpoint)
12:  0366959 !  2:  f1f88fe Preserve time fields in Jumbo by passing the comp args as defaults
    @@ -47,12 +47,12 @@
     @@
      
          for my $field (keys %$try) {
    -         $m->form_name('ModifyTicket');
    +         $m->form_name('TicketModifyAll');
     -        $m->field("${field}" => "1");
     +        $m->field($field => $try->{$field}) if defined $try->{$field};
              $m->select("${field}-TimeUnits" => 'hours');
              $m->click('AddMoreAttach');
    -         $m->form_name('ModifyTicket');
    +         $m->form_name('TicketModifyAll');
              is($m->value("${field}-TimeUnits"), 'hours', 'time units stayed to "hours" after the form was submitted');
     +        is(
     +            $m->value($field),
 4:  1609fa0 =  3:  7ffa0c1 Use $Action instead of $ARGS{'Action'} to get the 'default value' for free
 5:  dd4ef2e < --:  ------- EditTimeValue looks for InputUnits, not InUnits, so pass that instead
 6:  ace0855 < --:  ------- Cover time unit preservation among CF validation errors
 7:  31b9d7b < --:  ------- Change arguments from InUnits to InputUnits in the modile UI
 8:  f8c79b9 < --:  ------- Instead of InputUnits, use the request arg with the config fallback
 9:  79ef57d < --:  ------- Move time unit tests out of jumbo tests and into ticket basics
10:  cb0477c < --:  ------- Cover more field possibilities in the time unit tests
11:  b176245 < --:  ------- Test time unit preservation for tickets on the Jumbo page
13:  1492b7a !  4:  fcd9938 Preserve the rest of the ticket basics in Jumbo
    @@ -157,16 +157,16 @@
     +        if exists $try->{InitialPriority};
      
     +    $m->get( $url . "/Ticket/ModifyAll.html?id=" . $jumbo_ticket->id );
    -+    $m->form_name('ModifyTicket');
    ++    $m->form_name('TicketModifyAll');
     +    $m->set_fields(%$try);
     +    $m->click('AddMoreAttach');
    -+    $m->form_name('ModifyTicket');
    ++    $m->form_name('TicketModifyAll');
          for my $field (keys %$try) {
    --        $m->form_name('ModifyTicket');
    +-        $m->form_name('TicketModifyAll');
     -        $m->field($field => $try->{$field}) if defined $try->{$field};
     -        $m->select("${field}-TimeUnits" => 'hours');
     -        $m->click('AddMoreAttach');
    --        $m->form_name('ModifyTicket');
    +-        $m->form_name('TicketModifyAll');
     -        is($m->value("${field}-TimeUnits"), 'hours', 'time units stayed to "hours" after the form was submitted');
              is(
                  $m->value($field),
14:  42d12d1 =  5:  6dae9cd Improve coverage for testing preserved fields on failed CF validation