[Rt-commit] rt branch, 4.2/web-installer, created. rt-4.2.0-14-gb4517c1

[Alex Vandiver]

The branch, 4.2/web-installer has been created
        at  b4517c1453ca1e1f3cfa1948f8ddb485d8943794 (commit)

- Log -----------------------------------------------------------------
commit 44df99c6377c539af39ce1dd0b9226f195725642
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Fri Oct 4 13:01:07 2013 -0400

    Don't print anything to STDOUT during ACL granting
    
    When run under the web installer, output ot STDOUT is displayed in the
    browser.  This led to "Granting access to ..." being displayed atop the
    menu during the database initialization step.

diff --git a/etc/acl.mysql b/etc/acl.mysql
index 1688237..d06b8ae 100755
--- a/etc/acl.mysql
+++ b/etc/acl.mysql
@@ -12,7 +12,7 @@ sub acl {
         print STDERR "DatabaseUser is root. Skipping...\n";
         return;
     }
-    print "Granting access to $db_user\@'$db_rthost' on $db_name.\n";
+    print STDERR "Granting access to $db_user\@'$db_rthost' on $db_name.\n";
     $db_name =~ s/([_%])/\\$1/g;
     return (
         "GRANT SELECT,INSERT,CREATE,INDEX,UPDATE,DELETE

commit b4517c1453ca1e1f3cfa1948f8ddb485d8943794
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Fri Oct 4 13:02:05 2013 -0400

    Ensure that all classes (and thus roles) are loaded prior to bootstrap
    
    Bootstrapping involves creating some global role groups.  However, role
    group creation now checks the metadata on which roles are allowed on
    which objects.  As the core RT classes have not been loaded,
    RT::System->Roles is empty, so creation of global role groups fails with
    "ERROR: Invalid Group Name and Domain"
    
    Load RT classes prior to inserting bootstrapping data, to ensure that
    all roles are known.  t/web/install.t and t/web/installer.t did not
    catch this failure because they both fork a Plack server, which inherits
    all of the already-loaded modules from RT::Test -- and as such, all
    roles had always already been loaded.

diff --git a/share/html/Install/Initialize.html b/share/html/Install/Initialize.html
index 468662b..0fe40dc 100644
--- a/share/html/Install/Initialize.html
+++ b/share/html/Install/Initialize.html
@@ -119,6 +119,7 @@ if ( $Run ) {
                 $RT::Handle->dbh( undef );
                 RT::ConnectToDatabase();
                 RT::InitLogging();
+                RT::InitClasses();
                 ($status, $msg) = $RT::Handle->InsertInitialData;
             }
             elsif ( $action eq 'insert' ) {

-----------------------------------------------------------------------