[Rt-commit] rt branch, 4.2/previewscripmessages-regression, created. rt-4.2.0-27-gefc62aa

[Kevin Falcone]

The branch, 4.2/previewscripmessages-regression has been created
        at  efc62aaf565d9e66f2cf5a4ef15acac4809907bd (commit)

- Log -----------------------------------------------------------------
commit efc62aaf565d9e66f2cf5a4ef15acac4809907bd
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Wed Oct 23 12:17:47 2013 -0400

    Calling TemplateObj on a ScripAction is deprecated
    
    Unfortunately, the fallthrough code which should make this a deprecation
    warning, but still return an RT::Template object fails and returns
    undef.  This does not fix it to be back-compat but instead just switches
    to what I believe to be the correct code going forward.
    
    Discovered when PreviewScripMessages was turned on (defaults off) as
    reported in #26983

diff --git a/share/html/Ticket/Elements/PreviewScrips b/share/html/Ticket/Elements/PreviewScrips
index 133edff..809f9b3 100644
--- a/share/html/Ticket/Elements/PreviewScrips
+++ b/share/html/Ticket/Elements/PreviewScrips
@@ -88,7 +88,7 @@ my %squelched = ProcessTransactionSquelching( \%ARGS );
               </ul>
 %         }
 %         if (RT->Config->Get('PreviewScripMessages')) {
-              <textarea cols="80" rows="5"><%$scrip->ActionObj->TemplateObj->MIMEObj->as_string%></textarea>
+              <textarea cols="80" rows="5"><%$scrip->ActionObj->Action->TemplateObj->MIMEObj->as_string%></textarea>
 %         }
           <br />
 %     }

-----------------------------------------------------------------------