[Rt-commit] rt branch, 4.0/encode-base64-for-dashboard-html-email, created. rt-4.0.18-27-gd3cce81

? sunnavy sunnavy at bestpractical.com
Fri Oct 25 08:25:32 EDT 2013


The branch, 4.0/encode-base64-for-dashboard-html-email has been created
        at  d3cce810dda243968921e66418371b4cebb780f4 (commit)

- Log -----------------------------------------------------------------
commit d3cce810dda243968921e66418371b4cebb780f4
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Oct 25 20:07:06 2013 +0800

    set transfer encoding to base64 for dashboard html email
    
    there is line length limit for messages in rfc 2822(section 2.1.1).
    though some email systems can auto-wrap long lines perfectly, some did it poorly.
    dashboard html can have very long lines(1000+ chars, e.g. when there are links
    to customized searches with long queries), setting to base64 here is to make sure
    it won't be cut off by buggy email systems.

diff --git a/lib/RT/Dashboard/Mailer.pm b/lib/RT/Dashboard/Mailer.pm
index 9d28c49..c76eea4 100644
--- a/lib/RT/Dashboard/Mailer.pm
+++ b/lib/RT/Dashboard/Mailer.pm
@@ -422,6 +422,7 @@ sub BuildEmail {
         Type        => 'text/html',
         Charset     => 'UTF-8',
         Disposition => 'inline',
+        Encoding    => "base64",
     );
 
     for my $part (@parts) {

-----------------------------------------------------------------------


More information about the Rt-commit mailing list