[Rt-commit] [rtir] 01/03: This callback no longer functions in 4.0

[Kevin Falcone]

This is an automated email from the git hooks/post-receive script.

falcone pushed a commit to branch 3.0/filter-queuesummary
in repository rtir.

commit bd5fa656b7c1877ecac6badeb582ff17d62e23e8
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Tue Apr 1 15:03:30 2014 -0400

    This callback no longer functions in 4.0
    
    It was never updated when the RTIR specific QueueSummary was removed
    in 7044f2f1.  Back in 3.8, this hid all RTIR Queues from the RT homepage
    and then there was a custom RTIR portlet.  RTIR now just uses standard
    Quicksearch which dispatches off to QueueSummaryByLifecycle (or ByStatus
    if you prefer).  This means we need to filter only Constituency Queues.
    
    Instead of filtering after we get the Queue list, filter in SQL using
    the new callbacks in 4.0. This should be more efficient for sites with a
    bunch of Queues or Constituencies.
---
 html/Callbacks/RTIR/Elements/QueueSummary/Filter   | 56 ----------------------
 .../Elements/QueueSummaryByLifecycle/SQLFilter     | 12 +++++
 .../RTIR/Elements/QueueSummaryByStatus/SQLFilter   |  1 +
 3 files changed, 13 insertions(+), 56 deletions(-)

diff --git a/html/Callbacks/RTIR/Elements/QueueSummary/Filter b/html/Callbacks/RTIR/Elements/QueueSummary/Filter
deleted file mode 100644
index 99c00eb..0000000
--- a/html/Callbacks/RTIR/Elements/QueueSummary/Filter
+++ /dev/null
@@ -1,56 +0,0 @@
-%# BEGIN BPS TAGGED BLOCK {{{
-%#
-%# COPYRIGHT:
-%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
-%#                                          <sales at bestpractical.com>
-%#
-%# (Except where explicitly superseded by other copyright notices)
-%#
-%#
-%# LICENSE:
-%#
-%# This work is made available to you under the terms of Version 2 of
-%# the GNU General Public License. A copy of that license should have
-%# been provided with this software, but in any event can be snarfed
-%# from www.gnu.org.
-%#
-%# This work is distributed in the hope that it will be useful, but
-%# WITHOUT ANY WARRANTY; without even the implied warranty of
-%# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-%# General Public License for more details.
-%#
-%# You should have received a copy of the GNU General Public License
-%# along with this program; if not, write to the Free Software
-%# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
-%# 02110-1301 or visit their web page on the internet at
-%# http://www.gnu.org/licenses/old-licenses/gpl-2.0.html.
-%#
-%#
-%# CONTRIBUTION SUBMISSION POLICY:
-%#
-%# (The following paragraph is not intended to limit the rights granted
-%# to you to modify and distribute this software under the terms of
-%# the GNU General Public License and is only of importance to you if
-%# you choose to contribute your changes and enhancements to the
-%# community by submitting them to Best Practical Solutions, LLC.)
-%#
-%# By intentionally submitting any modifications, corrections or
-%# derivatives to this work, or any other work intended for use with
-%# Request Tracker, to Best Practical Solutions, LLC, you confirm that
-%# you are the copyright holder for those contributions and you grant
-%# Best Practical Solutions,  LLC a nonexclusive, worldwide, irrevocable,
-%# royalty-free, perpetual, license to use, copy, create derivative
-%# works based on those contributions, and sublicense and distribute
-%# those contributions and any derivatives thereof.
-%#
-%# END BPS TAGGED BLOCK }}}
-<%INIT>
-foreach my $q ( splice @$Queues ) {
-    next if $q->Name =~ /^(?:Incidents|Incident Reports|Investigations|Blocks)(?:\s*-\s*.*)?$/i;
-    push @$Queues, $q;
-}
-</%INIT>
-<%ARGS>
-$Queues => []
-</%ARGS>
diff --git a/html/Callbacks/RTIR/Elements/QueueSummaryByLifecycle/SQLFilter b/html/Callbacks/RTIR/Elements/QueueSummaryByLifecycle/SQLFilter
new file mode 100644
index 0000000..b5d7786
--- /dev/null
+++ b/html/Callbacks/RTIR/Elements/QueueSummaryByLifecycle/SQLFilter
@@ -0,0 +1,12 @@
+<%INIT>
+for my $type ('Incidents', 'Incident Reports', 'Investigations', 'Blocks') {
+    $Queues->Limit( FIELD => 'Name',
+                    OPERATOR => 'NOT STARTSWITH',
+                    VALUE => "$type - ",
+                    SUBCLAUSE => 'Constituencies',
+            );
+}
+</%INIT>
+<%ARGS>
+$Queues
+</%ARGS>
diff --git a/html/Callbacks/RTIR/Elements/QueueSummaryByStatus/SQLFilter b/html/Callbacks/RTIR/Elements/QueueSummaryByStatus/SQLFilter
new file mode 100644
index 0000000..ee26af6
--- /dev/null
+++ b/html/Callbacks/RTIR/Elements/QueueSummaryByStatus/SQLFilter
@@ -0,0 +1 @@
+<& /Callbacks/RTIR/Elements/QueueSummaryByLifecycle/SQLFilter, %ARGS &>

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.