[Rt-commit] [rtir] 01/03: This callback no longer functions in 4.0

Kevin Falcone falcone at bestpractical.com
Wed Apr 2 14:58:06 EDT 2014


This is an automated email from the git hooks/post-receive script.

falcone pushed a commit to branch 3.0/filter-queuesummary
in repository rtir.

commit 427256c4b7104371f17f16689dd2e839b0fae470
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Tue Apr 1 15:03:30 2014 -0400

    This callback no longer functions in 4.0
    
    It was never updated when the RTIR specific QueueSummary was removed
    in 7044f2f1.  Back in 3.8, this hid all RTIR Queues from the RT homepage
    and then there was a custom RTIR portlet.  RTIR now just uses standard
    Quicksearch which dispatches off to QueueSummaryByLifecycle (or ByStatus
    if you prefer).  This means we need to filter only Constituency Queues.
    
    Instead of filtering after we get the Queue list, filter in SQL using
    the new callbacks in 4.0. This should be more efficient for sites with a
    bunch of Queues or Constituencies.
---
 .../Filter => QueueSummaryByLifecycle/SQLFilter}              | 11 +++++++----
 .../{QueueSummary/Filter => QueueSummaryByStatus/SQLFilter}   | 10 +---------
 2 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/html/Callbacks/RTIR/Elements/QueueSummary/Filter b/html/Callbacks/RTIR/Elements/QueueSummaryByLifecycle/SQLFilter
similarity index 88%
copy from html/Callbacks/RTIR/Elements/QueueSummary/Filter
copy to html/Callbacks/RTIR/Elements/QueueSummaryByLifecycle/SQLFilter
index 99c00eb..810b5e0 100644
--- a/html/Callbacks/RTIR/Elements/QueueSummary/Filter
+++ b/html/Callbacks/RTIR/Elements/QueueSummaryByLifecycle/SQLFilter
@@ -46,11 +46,14 @@
 %#
 %# END BPS TAGGED BLOCK }}}
 <%INIT>
-foreach my $q ( splice @$Queues ) {
-    next if $q->Name =~ /^(?:Incidents|Incident Reports|Investigations|Blocks)(?:\s*-\s*.*)?$/i;
-    push @$Queues, $q;
+for my $type ('Incidents', 'Incident Reports', 'Investigations', 'Blocks') {
+    $Queues->Limit( FIELD => 'Name',
+                    OPERATOR => 'NOT STARTSWITH',
+                    VALUE => "$type - ",
+                    SUBCLAUSE => 'Constituencies',
+            );
 }
 </%INIT>
 <%ARGS>
-$Queues => []
+$Queues
 </%ARGS>
diff --git a/html/Callbacks/RTIR/Elements/QueueSummary/Filter b/html/Callbacks/RTIR/Elements/QueueSummaryByStatus/SQLFilter
similarity index 90%
rename from html/Callbacks/RTIR/Elements/QueueSummary/Filter
rename to html/Callbacks/RTIR/Elements/QueueSummaryByStatus/SQLFilter
index 99c00eb..aba638b 100644
--- a/html/Callbacks/RTIR/Elements/QueueSummary/Filter
+++ b/html/Callbacks/RTIR/Elements/QueueSummaryByStatus/SQLFilter
@@ -45,12 +45,4 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<%INIT>
-foreach my $q ( splice @$Queues ) {
-    next if $q->Name =~ /^(?:Incidents|Incident Reports|Investigations|Blocks)(?:\s*-\s*.*)?$/i;
-    push @$Queues, $q;
-}
-</%INIT>
-<%ARGS>
-$Queues => []
-</%ARGS>
+<& /Callbacks/RTIR/Elements/QueueSummaryByLifecycle/SQLFilter, %ARGS &>

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the rt-commit mailing list