[Rt-commit] rt branch, 4.0/reset-rt-at-a-glance, repushed

[Alex Vandiver]

The branch 4.0/reset-rt-at-a-glance was deleted and repushed:
       was ee1277fd5eb6ad88423762cbc84d725cbaf23105
       now 7d0236dc9438009b5f45a6b79ca8e8c2c9c40f31

--:  ------- >  1:  0b4868f Work around bugs in name resolution in SphinxSE on MySQL 5.5
--:  ------- >  2:  dc47610 Default to 127.0.0.1 in tests to work on MySQL 5.5
--:  ------- >  3:  1cdff0b Stop leaking an extra dbh during server startup
--:  ------- >  4:  4717d57 Explicitly disconnect the dbh before forking, if it exists
--:  ------- >  5:  3264659 Very rough pass to bring RT::StyleGuide up to date
--:  ------- >  6:  60dc4b1 I#28784: Tests for non-ASCII character in password
--:  ------- >  7:  2d3e94c I#28784: Handle non-ASCII character in passwod
--:  ------- >  8:  06ee3fb Correct POD for Lifecycle methods
--:  ------- >  9:  d3bfd07 Failing test when passing 0 to AddDays
--:  ------- > 10:  8ad1f86 Properly add zero days when zero is passed
--:  ------- > 11:  41f9505 all_pod_files_ok only checked lib/
--:  ------- > 12:  27af6e6 Warn about SetFieldsOnce
--:  ------- > 13:  01405be Note that changing queue subject tags may also require an $EmailSubjectTagRegex
--:  ------- > 14:  c58caef keep the original string in ParseFormat so we can reuse it in BuildFormatString
 1:  676fd12 = 15:  2898cad Add a method to remove a user preference
 2:  ac54896 ! 16:  f8547ec Add a "Reset" button to configuration of homepage portlets
    @@ -11,7 +11,7 @@
      
      </form>
      
    -+<&|/Widgets/TitleBox, title => loc("Reset adjustments") &>
    ++<&|/Widgets/TitleBox, title => loc("Reset") &>
     +<form method="post" name="ResetSearchOptions" action="Search.html">
     +<input type="hidden" name="Reset" value="1" />
     +<input type="hidden" name="name" value="<%$ARGS{name}%>" class="hidden" />
    @@ -33,7 +33,7 @@
     +    push @actions, $ok ? loc('Preferences saved.') : $msg;
     +}
     +
    - $title .= loc ($search->Description, loc ('"N"'));
    + $title .= loc (RT::SavedSearch->EscapeDescription($search->Description), loc ('"N"'));
      my $user = $session{'CurrentUser'}->UserObj;
      my $SearchArg = $user->Preferences($search, $search->Content);
     
 3:  eb5ecc0 = 17:  b3ddad9 Remove HomepageSettings preference on "reset" to pick up global defaults
 4:  ee1277f ! 18:  7d0236d Remove the session cache of the "RT at a Glance" portlet lists
    @@ -44,6 +44,7 @@
     -unless (exists $session{'my_rt_portlets'}) {
     -    my ($default_portlets) = RT::System->new($session{'CurrentUser'})->Attributes->Named('HomepageSettings');
     -    my $portlets = $default_portlets ? $default_portlets->Content : {};
    +-
     -    $session{'my_rt_portlets'} = $user->Preferences('HomepageSettings', $portlets);
     +my $portlets = $user->Preferences('HomepageSettings');
     +unless ($portlets) {
    @@ -53,7 +54,7 @@
     -my $portlets = $session{'my_rt_portlets'};
      
      my %seen;
    - my @items = map ["component-$_", $_], grep !$seen{$_}++, @{RT->Config->Get('HomepageComponents')};
    + my @items = map ["component-$_", loc($_)], grep !$seen{$_}++, @{RT->Config->Get('HomepageComponents')};
     @@
              my ( $conf, $pane ) = @_;
              my ($ok, $msg) = $user->SetPreferences( 'HomepageSettings', $conf );