[Rt-commit] rt branch, 4.2/html-external-formatter, repushed

[Alex Vandiver]

The branch 4.2/html-external-formatter was deleted and repushed:
       was f1b6b5943ed0eafd9508c293f97eb4d06d2e2495
       now 20d34db491141fb338453321b221d0b92e671f15

1:  08d992e ! 1:  8fc3d11 Use HTML::FormatExternal to allow external HTML → text formatters
    @@ -17,8 +17,8 @@
      
     +=item C<@HTMLFormatters>
     +
    -+The order of external HTML formatters to try; programs which are not
    -+found to be installed will be skipped.  C<core> is the internal perl
    ++The order of external HTML formatters to look for; programs which are
    ++not found to be installed will be skipped.  C<core> is the internal perl
     +converter, which is significantly faster than the others, but may fail
     +to successfully convert even on some relatively simple HTML.  Falls back
     +to C<core> if no explicitly listed option is available.
    @@ -81,7 +81,7 @@
     +    return $formatter if defined $formatter;
     +
     +    my @order = RT->Config->Get("HTMLFormatters");
    -+    # Always fall back to perl, even if it is not listed
    ++    # Always fall back to core, even if it is not listed
     +    for my $prog (@order, "core") {
     +        if ($prog eq "core") {
     +            RT->Logger->info("Using internal Perl HTML -> text conversion");
    @@ -100,6 +100,7 @@
     +                };
     +            };
     +        }
    ++        RT->Config->Set( HTMLFormatters => [$prog] );
     +        last;
     +    }
     +    return $formatter;
2:  b57d706 ! 2:  953e238 Add HTML::HTML5::ToText as a better pure-perl HTML → text converter
    @@ -6,8 +6,8 @@
     --- a/etc/RT_Config.pm.in
     +++ b/etc/RT_Config.pm.in
     @@
    - The order of external HTML formatters to try; programs which are not
    - found to be installed will be skipped.  C<core> is the internal perl
    + The order of external HTML formatters to look for; programs which are
    + not found to be installed will be skipped.  C<core> is the internal perl
      converter, which is significantly faster than the others, but may fail
     -to successfully convert even on some relatively simple HTML.  Falls back
     -to C<core> if no explicitly listed option is available.
3:  cf0b300 = 3:  dd1829a HTML::HTML5::ToText mistakenly installs a global __WARN__ handler; local it
4:  2e29532 < -:  ------- Update HTMLFormatters to just one formatter after it is chosen
5:  f1b6b59 = 4:  20d34db Update tests to work with any of the HTML formatters