[Rt-commit] rt branch, 4.2/autocomplete-new, created. rt-4.2.3-83-g080f69c

[Alex Vandiver]

The branch, 4.2/autocomplete-new has been created
        at  080f69c815af855c870931f7b01f18ea969379f5 (commit)

- Log -----------------------------------------------------------------
commit 080f69c815af855c870931f7b01f18ea969379f5
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Apr 7 18:36:17 2014 -0400

    Don't provide "new" as an id to skip
    
    Postgres complains heartily if a limit contains a string for an integer
    column -- as happens if data-autocomplete-exclude is "new" and we
    attempt to exclude tickets matching that id.

diff --git a/share/html/Elements/AddLinks b/share/html/Elements/AddLinks
index 77d0343..74b2372 100644
--- a/share/html/Elements/AddLinks
+++ b/share/html/Elements/AddLinks
@@ -54,6 +54,9 @@ $ARGSRef        => $DECODED_ARGS
 my $id = ($Object and $Object->id)
     ? $Object->id
     : "new";
+
+my $exclude = qq| data-autocomplete="Tickets" data-autocomplete-multiple="1"|;
+$exclude .= qq| data-autocomplete-exclude="$id"| if $Object->id;
 </%init>
 % if (ref($Object) eq 'RT::Ticket') {
 <i><&|/l&>Enter tickets or URIs to link tickets to. Separate multiple entries with spaces.</&>
@@ -69,27 +72,27 @@ my $id = ($Object and $Object->id)
 <table>
   <tr>
     <td class="label"><& ShowRelationLabel, Object => $Object, Label => loc('Depends on').':', Relation => 'DependsOn' &></td>
-    <td class="entry"><input name="<%$id%>-DependsOn" value="<% $ARGSRef->{"$id-DependsOn"} || '' %>" data-autocomplete="Tickets" data-autocomplete-exclude="<% $id %>" data-autocomplete-multiple="1" /></td>
+    <td class="entry"><input name="<%$id%>-DependsOn" value="<% $ARGSRef->{"$id-DependsOn"} || '' %>" <% $exclude |n%>/></td>
   </tr>
   <tr>
     <td class="label"><& ShowRelationLabel, Object => $Object, Label => loc('Depended on by').':', Relation => 'DependedOnBy' &></td>
-    <td class="entry"><input name="DependsOn-<%$id%>" value="<% $ARGSRef->{"DependsOn-$id"} || '' %>" data-autocomplete="Tickets" data-autocomplete-exclude="<% $id %>" data-autocomplete-multiple="1" /></td>
+    <td class="entry"><input name="DependsOn-<%$id%>" value="<% $ARGSRef->{"DependsOn-$id"} || '' %>" <% $exclude |n%>/></td>
   </tr>
   <tr>
     <td class="label"><& ShowRelationLabel, Object => $Object, Label => loc('Parents').':', Relation => 'Parents' &></td>
-    <td class="entry"><input name="<%$id%>-MemberOf" value="<% $ARGSRef->{"$id-MemberOf"} || '' %>" data-autocomplete="Tickets" data-autocomplete-exclude="<% $id %>" data-autocomplete-multiple="1" /></td>
+    <td class="entry"><input name="<%$id%>-MemberOf" value="<% $ARGSRef->{"$id-MemberOf"} || '' %>" <% $exclude |n%>/></td>
   </tr>
   <tr>
     <td class="label"><& ShowRelationLabel, Object => $Object, Label => loc('Children').':', Relation => 'Children' &></td>
-    <td class="entry"> <input name="MemberOf-<%$id%>" value="<% $ARGSRef->{"MemberOf-$id"} || '' %>" data-autocomplete="Tickets" data-autocomplete-exclude="<% $id %>" data-autocomplete-multiple="1" /></td>
+    <td class="entry"> <input name="MemberOf-<%$id%>" value="<% $ARGSRef->{"MemberOf-$id"} || '' %>" <% $exclude |n%>/></td>
   </tr>
   <tr>
     <td class="label"><& ShowRelationLabel, Object => $Object, Label => loc('Refers to').':', Relation => 'RefersTo' &></td>
-    <td class="entry"><input name="<%$id%>-RefersTo" value="<% $ARGSRef->{"$id-RefersTo"} || '' %>" data-autocomplete="Tickets" data-autocomplete-exclude="<% $id %>" data-autocomplete-multiple="1" /></td>
+    <td class="entry"><input name="<%$id%>-RefersTo" value="<% $ARGSRef->{"$id-RefersTo"} || '' %>" <% $exclude |n%>/></td>
   </tr>
   <tr>
     <td class="label"><& ShowRelationLabel, Object => $Object, Label => loc('Referred to by').':', Relation => 'ReferredToBy' &></td>
-    <td class="entry"> <input name="RefersTo-<%$id%>" value="<% $ARGSRef->{"RefersTo-$id"} || '' %>" data-autocomplete="Tickets" data-autocomplete-exclude="<% $id %>" data-autocomplete-multiple="1" /></td>
+    <td class="entry"> <input name="RefersTo-<%$id%>" value="<% $ARGSRef->{"RefersTo-$id"} || '' %>" <% $exclude |n%>/></td>
   </tr>
   <& /Elements/EditCustomFields,
         Object          => $Object,

-----------------------------------------------------------------------