[Rt-commit] rt branch, 4.2/inline-server-failed-tests, created. rt-4.2.3-85-gf253468

[? sunnavy]

The branch, 4.2/inline-server-failed-tests has been created
        at  f2534682a5400db1cf27b760819940b7a2be461b (commit)

- Log -----------------------------------------------------------------
commit 44fbf0a8f8dfbe402d7d5e0789ff1d5bbf6ab203
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Apr 16 01:25:26 2014 +0800

    require actual_server since mailgate is called there

diff --git a/t/mail/smime/incoming.t b/t/mail/smime/incoming.t
index 50707a0..918844a 100644
--- a/t/mail/smime/incoming.t
+++ b/t/mail/smime/incoming.t
@@ -1,7 +1,7 @@
 use strict;
 use warnings;
 
-use RT::Test::SMIME tests => undef;
+use RT::Test::SMIME tests => undef, actual_server => 1;
 my $test = 'RT::Test::SMIME';
 
 use IPC::Run3 'run3';
diff --git a/t/mail/smime/reject_on_unencrypted.t b/t/mail/smime/reject_on_unencrypted.t
index f8d61ad..ab62d83 100644
--- a/t/mail/smime/reject_on_unencrypted.t
+++ b/t/mail/smime/reject_on_unencrypted.t
@@ -1,7 +1,7 @@
 use strict;
 use warnings;
 
-use RT::Test::SMIME tests => undef, config => 'Set( %Crypt, RejectOnUnencrypted => 1 );';
+use RT::Test::SMIME tests => undef, actual_server => 1, config => 'Set( %Crypt, RejectOnUnencrypted => 1 );';
 my $test = 'RT::Test::SMIME';
 
 use IPC::Run3 'run3';

commit f2534682a5400db1cf27b760819940b7a2be461b
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Apr 16 01:35:50 2014 +0800

    missed one warning check, which causes tests to fail in inline server mode
    
    the error is like:
    
    Unhandled warning: Couldn't auto-create user 'conflicting' when attempting WebRemoteUser: Email address in use
    DESTROY created new reference to dead object 'Plack::Middleware::Test::StashWarnings' during global destruction.
    DESTROY created new reference to dead object 'Plack::Middleware::Test::StashWarnings' during global destruction.

diff --git a/t/web/remote_user.t b/t/web/remote_user.t
index 7a58388..c17a933 100644
--- a/t/web/remote_user.t
+++ b/t/web/remote_user.t
@@ -185,6 +185,7 @@ diag "WebRemoteUserAutocreate";
         $m->auth("conflicting");
         $m->get($url);
         is $m->status, 403, "Forbidden";
+        $m->next_warning_like(qr/Couldn't auto-create user 'conflicting' when attempting WebRemoteUser: Email address in use/, 'found failed auth warning');
 
         my $user = RT::User->new( RT->SystemUser );
         $user->Load("conflicting");

-----------------------------------------------------------------------