[Rt-commit] rt branch, 4.2/ascii-rightnames, created. rt-4.2.3-87-g0810f87

[Alex Vandiver]

The branch, 4.2/ascii-rightnames has been created
        at  0810f874c0ac60e878c0c82ffdfc84fa60d426b7 (commit)

- Log -----------------------------------------------------------------
commit 0810f874c0ac60e878c0c82ffdfc84fa60d426b7
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Apr 17 16:28:03 2014 -0400

    Warn on non-ASCII right names; mysql's RightName column is ASCII
    
    Fixes I#19339.

diff --git a/lib/RT/Lifecycle.pm b/lib/RT/Lifecycle.pm
index 659a648..eb7c24c 100644
--- a/lib/RT/Lifecycle.pm
+++ b/lib/RT/Lifecycle.pm
@@ -686,6 +686,10 @@ sub FillCache {
                 unless $from eq '*' or $lifecycle->{canonical_case}{lc $from};
             warn "Nonexistant status @{[lc $to]} in right transition in $name lifecycle"
                 unless $to eq '*' or $lifecycle->{canonical_case}{lc $to};
+
+            warn "Invalid right name ($lifecycle->{rights}{$schema}) in $name lifecycle; right names must be ASCII"
+                if $lifecycle->{rights}{$schema} =~ /\P{ASCII}/;
+
             $lifecycle->{rights}{lc($from) . " -> " .lc($to)}
                 = delete $lifecycle->{rights}{$schema};
         }

-----------------------------------------------------------------------