[Rt-commit] rt branch, 4.2/charts-upgrade-content, created. rt-4.2.3-169-gf2f6bbe

[Wallace Reis]

The branch, 4.2/charts-upgrade-content has been created
        at  f2f6bbe5c05bc09f3ba026502e65a9b59755829e (commit)

- Log -----------------------------------------------------------------
commit f2f6bbe5c05bc09f3ba026502e65a9b59755829e
Author: Wallace Reis <wreis at bestpractical.com>
Date:   Sat Apr 26 15:19:10 2014 -0300

    I#29595: Undef foolproof for PrimaryGroupBy on upgrade
    
    In 4.0, when we process the submitted form for save chart operation
    without changing any option in the dropdowns (either ChartStyle or
    PrimaryGroupBy), then there isn't any value in the %ARGS which causes
    these options to be saved as undef in DB. Additionally, that is the
    same behavior for 4.2. Thus, we need to mangle the upgrade content
    scripts to undef foolproof when handling PrimaryGroupBy to avoid the
    warnings.

diff --git a/etc/upgrade/4.1.17/content b/etc/upgrade/4.1.17/content
index 3454f78..5e04873 100644
--- a/etc/upgrade/4.1.17/content
+++ b/etc/upgrade/4.1.17/content
@@ -15,7 +15,7 @@ our @Initial = (sub {
         # Switch from "CreatedMonthly" to "Created.Monthly"
         $content->{GroupBy} ||= [delete $content->{PrimaryGroupBy}];
         for (@{$content->{GroupBy}}) {
-            next if /\./;
+            next if not defined || /\./;
             s/(?<=[a-z])(?=[A-Z])/./;
         }
 

-----------------------------------------------------------------------