[Rt-commit] rt branch, 4.2/watcher-insensitive, created. rt-4.2.3-173-g600f929

Alex Vandiver alexmv at bestpractical.com
Wed Apr 30 13:35:00 EDT 2014


The branch, 4.2/watcher-insensitive has been created
        at  600f9294e4ebf4afa452dc8572f4dfdb4f417720 (commit)

- Log -----------------------------------------------------------------
commit f71b1fa8e4585456bfd4af1a346d25e1a69b3ae1
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed Apr 30 13:34:07 2014 -0400

    Perform user/group searches case-insensitively
    
    Fixes I#27835.

diff --git a/share/html/Ticket/Elements/AddWatchers b/share/html/Ticket/Elements/AddWatchers
index 482d289..721ceb6 100644
--- a/share/html/Ticket/Elements/AddWatchers
+++ b/share/html/Ticket/Elements/AddWatchers
@@ -110,14 +110,14 @@ my ($Users, $Groups);
 
 if ($UserString) {
     $Users = RT::Users->new($session{'CurrentUser'});
-    $Users->Limit(FIELD => $UserField, VALUE => $UserString, OPERATOR => $UserOp);
+    $Users->Limit(FIELD => $UserField, VALUE => $UserString, OPERATOR => $UserOp, CASESENSITIVE => 0);
     $Users->LimitToPrivileged if $PrivilegedOnly;
      }
 
 if ($GroupString) {
     $Groups = RT::Groups->new($session{'CurrentUser'});
     $Groups->LimitToUserDefinedGroups;
-    $Groups->Limit(FIELD => $GroupField, VALUE => $GroupString, OPERATOR => $GroupOp);
+    $Groups->Limit(FIELD => $GroupField, VALUE => $GroupString, OPERATOR => $GroupOp, CASESENSITIVE => 0);
      }
 
 my @extras;

commit 600f9294e4ebf4afa452dc8572f4dfdb4f417720
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed Apr 30 13:34:37 2014 -0400

    Fix indentation

diff --git a/share/html/Ticket/Elements/AddWatchers b/share/html/Ticket/Elements/AddWatchers
index 721ceb6..5ac0c04 100644
--- a/share/html/Ticket/Elements/AddWatchers
+++ b/share/html/Ticket/Elements/AddWatchers
@@ -112,22 +112,22 @@ if ($UserString) {
     $Users = RT::Users->new($session{'CurrentUser'});
     $Users->Limit(FIELD => $UserField, VALUE => $UserString, OPERATOR => $UserOp, CASESENSITIVE => 0);
     $Users->LimitToPrivileged if $PrivilegedOnly;
-     }
+}
 
 if ($GroupString) {
     $Groups = RT::Groups->new($session{'CurrentUser'});
     $Groups->LimitToUserDefinedGroups;
     $Groups->Limit(FIELD => $GroupField, VALUE => $GroupString, OPERATOR => $GroupOp, CASESENSITIVE => 0);
-     }
+}
 
 my @extras;
 for my $addr ( values %{$Ticket->TransactionAddresses} ) {
     my $is_watcher;
     for my $type ( qw/Owner Requestor Cc AdminCc/ ) {
-         if ($Ticket->IsWatcher( Email => $addr->address, Type => $type )) {
-             $is_watcher = 1;
-             last;
-         }
+        if ($Ticket->IsWatcher( Email => $addr->address, Type => $type )) {
+            $is_watcher = 1;
+            last;
+        }
     }
     push @extras, $addr unless $is_watcher;
 }

-----------------------------------------------------------------------


More information about the rt-commit mailing list