[Rt-commit] rt branch, 4.2/still-defer-history-loading-when-showing-headers, created. rt-4.2.6-36-g1ff7f30

[Kevin Falcone]

The branch, 4.2/still-defer-history-loading-when-showing-headers has been created
        at  1ff7f30c983bb383d9d621cfbfcbd40094fa051d (commit)

- Log -----------------------------------------------------------------
commit 1ff7f30c983bb383d9d621cfbfcbd40094fa051d
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Wed Aug 13 14:40:43 2014 -0400

    Still delay loading when showing headers
    
    In 75a405b5 we added the ForceShowHistory flag to Click to load history
    so that even if your JS was off, clicking on the link would load the
    page.
    
    This flag is also found in the Show Headers links added in 1a3327ce
    and I think added so that when you clicked on ShowHeaders with Click to
    load enable, you didn't *then* have to click on "Load history" just to
    see the headers.
    
    However, with delay, we already passed ShowHeaders to the helper, but
    clicking on Show Headers forced us to do the page load inline instead.
    This negates all of the perceived speed boost from delayed loading.
    Removing it from the delay case hasn't immediately broken things, and
    the delayed loading really doesn't play well with having JS off anyway.

diff --git a/share/html/Ticket/Display.html b/share/html/Ticket/Display.html
index 949edff..46012d8 100644
--- a/share/html/Ticket/Display.html
+++ b/share/html/Ticket/Display.html
@@ -67,7 +67,7 @@
 % $m->callback( Ticket => $TicketObj, %ARGS, Transactions => $transactions, Attachments => $attachments, CallbackName => 'BeforeShowHistory' );
 
 % my $ShowHistory = RT->Config->Get("ShowHistory", $session{'CurrentUser'});
-% if (not $ForceShowHistory and $ShowHistory eq "delay") {
+% if ($ShowHistory eq "delay") {
     <& /Ticket/Elements/DelayShowHistory,
         Ticket => $TicketObj,
         ShowHeaders => $ARGS{'ShowHeaders'},

-----------------------------------------------------------------------