[Rt-commit] rt branch, 4.2-trunk, updated. rt-4.2.6-47-g1ead0f9

[Alex Vandiver]

The branch, 4.2-trunk has been updated
       via  1ead0f9935d518d95b73c6e4dab8f82a45eb8ba5 (commit)
      from  89684dcfc87783c42832fe8054af1ded01f8723c (commit)

Summary of changes:
 lib/RT/PlackRunner.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit 1ead0f9935d518d95b73c6e4dab8f82a45eb8ba5
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Aug 18 14:16:50 2014 -0400

    rt-server: properly protect against lack of --listen
    
    Not passing --listen causes $args{listen} to be undef, which cannot be
    de-referenced as an array reference.  Fall back to [] to ensure that
    this dies with the useful message, and not "Can't use an undefined value
    as an ARRAY reference"

diff --git a/lib/RT/PlackRunner.pm b/lib/RT/PlackRunner.pm
index 45c5161..07a6740 100644
--- a/lib/RT/PlackRunner.pm
+++ b/lib/RT/PlackRunner.pm
@@ -133,7 +133,7 @@ sub run {
     # Plack::Handler::FCGI has its own catch for this, but doesn't
     # notice that listen is an empty list, and we can also provide a
     # better error message.
-    if ($self->{server} eq "FCGI" and not -S STDIN and not @{$args{listen}}) {
+    if ($self->{server} eq "FCGI" and not -S STDIN and not @{$args{listen} || []}) {
         print STDERR "STDIN is not a socket, and no --listen, --socket, or --port provided\n";
         exit 1;
     }

-----------------------------------------------------------------------