[Rt-commit] rt branch, 4.2/record-attachments-dropping, repushed

[? sunnavy]

The branch 4.2/record-attachments-dropping was deleted and repushed:
       was cac2bcff502dff07d679bcb19d08b93347857929
       now 5d1089ff1bcb8653cd9f205c712d067a5ce3e68c

1:  15dddd2 = 1:  15dddd2 record attachments' dropping/truncation as txns
2:  1545237 = 2:  1545237 test attachment dropping/truncation
3:  4aaa132 = 3:  4aaa132 make attachment truncate/drop and error txns more noticeable
4:  cac2bcf ! 4:  5d1089f refactor email sent failure system error txn to use the same tech as Attachment Truncate/Drop.
    @@ -2,7 +2,8 @@
     
         refactor email sent failure system error txn to use the same tech as Attachment Truncate/Drop.
         
    -    it's more simple and secure: by specifying ActivateScrips to 0, it won't cause infinite-loop.
    +    it's more simple and secure: by specifying ActivateScrips to 0, it won't cause infinite-loop,
    +    which could happen if the system error txn triggers some scrips to send mails.
     
     diff --git a/lib/RT/Interface/Email.pm b/lib/RT/Interface/Email.pm
     --- a/lib/RT/Interface/Email.pm
    @@ -16,7 +17,7 @@
     -            Content => "Sending the previous mail has failed.  Please contact your admin, they can find more details in the logs.",
     +        $ticket->_NewTransaction(
     +            Type => "SystemError",
    -+            Data => "Sending the previous mail has failed.  Please contact your admin, they can find more details in the logs.",
    ++            Data => "Sending the previous mail has failed.  Please contact your admin, they can find more details in the logs.", #loc
     +            ActivateScrips => 0,
              );
              return 1;