[Rt-commit] rt branch, 4.0/user-prefs-button-order, created. rt-4.0.21-19-gddb2cf9

[Wallace Reis]

The branch, 4.0/user-prefs-button-order has been created
        at  ddb2cf9d76b68d18055e4de1b7a71c5867876fd9 (commit)

- Log -----------------------------------------------------------------
commit ddb2cf9d76b68d18055e4de1b7a71c5867876fd9
Author: Wallace Reis <wreis at bestpractical.com>
Date:   Wed Aug 27 17:58:10 2014 -0300

    Button ordering on update user page
    
    1b39bc1c tried to address this issue, however modern browsers still
    submit the form when hitting enter. The 1b39bc1c changeset provides
    a good UX tho, by hiding the "Reset Auth Token" button.
    
    Thus, a proper solution is to put the save submit button first in
    the source since browser uses the first one as default button when
    hitting enter and it doesn't make a lot of sense UI-wise to have
    the button between the form fields and their submit element anyway.
    
    Fixes I#19431.

diff --git a/share/html/User/Prefs.html b/share/html/User/Prefs.html
index d91a149..c1d2957 100644
--- a/share/html/User/Prefs.html
+++ b/share/html/User/Prefs.html
@@ -167,6 +167,8 @@
 </table>
 </&>
 
+<& /Elements/Submit, Label => loc('Save Preferences') &>
+
 <&| /Widgets/TitleBox, title => loc('Secret authentication token'), id => "user-prefs-feeds" &>
 
 <&|/l&>All iCal feeds embed a secret token which authorizes you.  If the URL one of your iCal feeds got exposed to the outside world, you can get a new secret, <b>breaking all existing iCal feeds</b> below.</&>
@@ -196,7 +198,6 @@
 
 % $m->callback( %ARGS, UserObj => $UserObj, CallbackName => 'FormEnd' );
 
-<& /Elements/Submit, Label => loc('Save Preferences') &>
 </form>
 
 

-----------------------------------------------------------------------