[Rt-commit] rt branch, 4.0/gpg-show-warnings-early-and-always-update, created. rt-4.0.22-21-g5f32a99

[Todd Wade]

The branch, 4.0/gpg-show-warnings-early-and-always-update has been created
        at  5f32a992ba29c7733ab87cdc25b5bcbf5cc6df4f (commit)

- Log -----------------------------------------------------------------
commit 5f32a992ba29c7733ab87cdc25b5bcbf5cc6df4f
Author: Todd Wade <todd at bestpractical.com>
Date:   Thu Dec 4 10:44:41 2014 -0500

    show warning on page load and update ticket regardless of errors
    
    Pre-commit code only showed warning after submitting the ticket update, and
    prohibited update from proceeding. This change shows the warning on page
    entry and allows the update to proceed even if public key for the email
    address is not available.

diff --git a/share/html/Ticket/Update.html b/share/html/Ticket/Update.html
index 9501b5c..766dbaf 100644
--- a/share/html/Ticket/Update.html
+++ b/share/html/Ticket/Update.html
@@ -253,12 +253,19 @@ $CanComment = 1 if ( $TicketObj->CurrentUserHasRight('CommentOnTicket') or
 
 ProcessAttachments(ARGSRef => \%ARGS);
 
-my $gnupg_widget = $m->comp('/Elements/GnuPG/SignEncryptWidget:new', Arguments => \%ARGS );
+my $gnupg_widget = $m->comp('/Elements/GnuPG/SignEncryptWidget:new',
+    Arguments => { UpdateType => $type, %ARGS }
+);
 $m->comp( '/Elements/GnuPG/SignEncryptWidget:Process',
     self => $gnupg_widget,
     TicketObj => $TicketObj,
 );
 
+$m->comp('/Elements/GnuPG/SignEncryptWidget:Check',
+    self      => $gnupg_widget,
+    TicketObj => $TicketObj,
+);
+
 if ( $ARGS{'SubmitTicket'} ) {
 
     my %squelched = ProcessTransactionSquelching( \%ARGS );
@@ -278,11 +285,7 @@ if ( $ARGS{'SubmitTicket'} ) {
             push @results, loc($CF->Name) . ': ' . $msg;
         }
     }
-    my $status = $m->comp('/Elements/GnuPG/SignEncryptWidget:Check',
-        self      => $gnupg_widget,
-        TicketObj => $TicketObj,
-    );
-    $checks_failure = 1 unless $status;
+
 }
 
 # check email addresses for RT's

-----------------------------------------------------------------------