[Rt-commit] rt branch, 4.2-trunk, updated. rt-4.2.9-53-gd4e8eca

Alex Vandiver alexmv at bestpractical.com
Thu Dec 11 15:51:52 EST 2014


The branch, 4.2-trunk has been updated
       via  d4e8eca9ffb5ec2b7f86b04ea8f8332ab4ad932f (commit)
       via  0145d49c0dbc353cd2ce375bc45ff8056e2905cb (commit)
      from  b827a0dc261378161b1370484dfb0638dc77a3b1 (commit)

Summary of changes:
 share/html/Elements/EditCustomFieldCustomGroupings | 2 +-
 share/html/Elements/ShowCustomFieldCustomGroupings | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit 0145d49c0dbc353cd2ce375bc45ff8056e2905cb
Author: Christian Loos <cloos at netcologne.de>
Date:   Thu Dec 11 14:07:52 2014 +0100

    Let CF box on Display page link to subsection of editing page
    
    Additionally to aca8b3b9cecb55072d5efc0efedbca04e7f2222a for users with lot of
    CFs in groups AND CFs not in groups, this lets you jump to the right place
    if you choose to edit a CF which isn't in groups.

diff --git a/share/html/Elements/EditCustomFieldCustomGroupings b/share/html/Elements/EditCustomFieldCustomGroupings
index cb7484c..bf0cea2 100644
--- a/share/html/Elements/EditCustomFieldCustomGroupings
+++ b/share/html/Elements/EditCustomFieldCustomGroupings
@@ -49,7 +49,7 @@
 <&| /Widgets/TitleBox,
     title => $group? loc($group) : loc('Custom Fields'),
     class => $css_class .' '. ($group? CSSClass("$css_class-$group") : ''),
-    ($group ? (id => CSSClass("$css_class-$group")) : ()),
+    id    => ($group ? CSSClass("$css_class-$group") : $css_class),
     hide_empty => 1,
     %$TitleBoxARGS,
 &>
diff --git a/share/html/Elements/ShowCustomFieldCustomGroupings b/share/html/Elements/ShowCustomFieldCustomGroupings
index 2959be2..c7e34e6 100644
--- a/share/html/Elements/ShowCustomFieldCustomGroupings
+++ b/share/html/Elements/ShowCustomFieldCustomGroupings
@@ -51,7 +51,7 @@ for my $group ( @Groupings ) {
         title => $group? loc($group) : loc('Custom Fields'),
         class => $css_class .' '. ($group? CSSClass("$css_class-$group") : ''),
         hide_empty => 1,
-        title_href => $title_href ? "$title_href?id=".$Object->id.($group?";Grouping=".$m->interp->apply_escapes($group,'u')."#".CSSClass("$css_class-$group") : '') : undef,
+        title_href => $title_href ? "$title_href?id=".$Object->id.($group?";Grouping=".$m->interp->apply_escapes($group,'u')."#".CSSClass("$css_class-$group") : "#".$css_class) : undef,
         %$TitleBoxARGS,
     );
     $m->callback( CallbackName => 'TitleBox', Object => $Object, Grouping => $group, ARGSRef => \%grouping_args );

commit d4e8eca9ffb5ec2b7f86b04ea8f8332ab4ad932f
Merge: b827a0d 0145d49
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Dec 11 15:51:30 2014 -0500

    Merge branch '4.2/cf-anchor' into 4.2-trunk


-----------------------------------------------------------------------


More information about the rt-commit mailing list