[Rt-commit] rt branch, 4.2/group-as-requestor, created. rt-4.2.9-60-g4d684c4
Wallace Reis
wreis at bestpractical.com
Tue Dec 23 13:16:39 EST 2014
The branch, 4.2/group-as-requestor has been created
at 4d684c4839d81eb95c7dad992f779998801f6d89 (commit)
- Log -----------------------------------------------------------------
commit 4d684c4839d81eb95c7dad992f779998801f6d89
Author: Wallace Reis <wreis at bestpractical.com>
Date: Tue Dec 23 15:00:28 2014 -0300
Allow Groups be added as Requestor
The "Scope" argument is used to determine if we're trying to list the
watcher types we can change on queues or anything else -- which for the
later case includes "Requestor" besides the common "AdminCc" and "Cc"
types.
This came about in 6020dac5, which is a famously unhelpful giant lump
commit from the 2.1 days, so it doesn't have any justification provided
in the commit message for why the groups are treated differently than
the queues.
Thus, it removes the "Scope" param in order to fall into default case
as for the user's call.
diff --git a/share/html/Ticket/Elements/AddWatchers b/share/html/Ticket/Elements/AddWatchers
index 5ac0c04..8a0d74d 100644
--- a/share/html/Ticket/Elements/AddWatchers
+++ b/share/html/Ticket/Elements/AddWatchers
@@ -69,7 +69,7 @@
<&|/l&>Group</&>
</td></tr>
% while (my $g = $Groups->Next ) {
-<tr><td><&/Elements/SelectWatcherType, Name => "Ticket-AddWatcher-Principal-".$g->PrincipalId, Scope => 'queue' &></td><td><%$g->Name%> (<%$g->Description%>)</td></tr>
+<tr><td><&/Elements/SelectWatcherType, Name => "Ticket-AddWatcher-Principal-".$g->PrincipalId &></td><td><%$g->Name%> (<%$g->Description%>)</td></tr>
% }
% }
-----------------------------------------------------------------------
More information about the rt-commit
mailing list