[Rt-commit] rt branch, 4.2/html-external-formatter, repushed

Alex Vandiver alexmv at bestpractical.com
Wed Dec 31 14:43:32 EST 2014


The branch 4.2/html-external-formatter was deleted and repushed:
       was 6449b2eecc652c63642f8cb231a17a739c0b9d00
       now 568f22a5db4aca745d68095fe6fab59c9fb8aee2

1:  2499d7e ! 1:  d9507ef Use HTML::FormatExternal to allow external HTML → text formatters
    @@ -63,7 +63,7 @@
      use Email::Address;
      use MIME::Entity;
     @@
    - use UNIVERSAL::require;
    + use File::Temp;
      use Mail::Mailer ();
      use Text::ParseWords qw/shellwords/;
     +use RT::Util 'safe_run_child';
2:  4fefae3 = 2:  e21f248 Allow $HTMLFormatter to contain the full path
3:  77f6139 = 3:  1a39cd1 Provide a default PATH in cases where it is unset (mod_fastcgi)
4:  58b3db3 < -:  ------- Add HTML::HTML5::ToText as a better pure-perl HTML → text converter
5:  5a54a02 < -:  ------- HTML::HTML5::ToText mistakenly installs a global __WARN__ handler; local it
-:  ------- > 4:  296d5c2 Set an $ENV{HOME} that the external formatters can write under
6:  6449b2e ! 5:  568f22a Update tests to work with any of the HTML formatters
    @@ -16,17 +16,6 @@
     diff --git a/t/mail/html-outgoing.t b/t/mail/html-outgoing.t
     --- a/t/mail/html-outgoing.t
     +++ b/t/mail/html-outgoing.t
    -@@
    - BEGIN {
    -     plan skip_all => 'Email::Abstract and Test::Email required.'
    -         unless eval { require Email::Abstract; require Test::Email; 1 };
    --    plan tests => 22;
    - }
    - 
    -+
    - use RT::Test::Email;
    - use Test::Warn;
    - 
     @@
          to      => 'enduser at example.com',
          subject => qr/\Q[example.com #1] AutoReply: The internet is broken\E/,
    @@ -131,11 +120,3 @@
      
              '<p>This is a comment about <a href="http://localhost:\d+/Ticket/Display\.html\?id=1">ticket 1</a>\. '.
              'It is not sent to the Requestor\(s\):</p>.+?'.
    -@@
    -     'Content-Type' => qr{multipart},
    - };
    - 
    -+done_testing;
    - 
    - sub parts_regex {
    -     my ($text, $html) = @_;



More information about the rt-commit mailing list