[Rt-commit] rt branch, 4.0/bulk-links-after-deletion, created. rt-4.0.19-7-g2136966

[Alex Vandiver]

The branch, 4.0/bulk-links-after-deletion has been created
        at  2136966eed4a9805bd6f53c352f3fe6d2025692c (commit)

- Log -----------------------------------------------------------------
commit 2136966eed4a9805bd6f53c352f3fe6d2025692c
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed Feb 5 12:54:09 2014 -0500

    Ensure that the query is re-run after a bulk update
    
    While the CollectionList at the top of the Bulk Update re-runs the query
    after an update (by dint of being passed the TicketSQL and not
    $Tickets), the BulkLinks collection is not so lucky.  As such, it
    contains the data from before the update was applied.
    
    However, this can lead to internal inconsistency -- namely, if the
    tickets were deleted, Count on $Tickets will return the old cached
    value, while ->Next will skip the newly-deleted tickets.  This causes
    BulkLinks to error out with "Can't call method "DependsOn" on an
    undefined value", as it assumes ->Next will be true if ->Count was.
    
    Ensure that the $Tickets collection is re-run if a bulk update was made.

diff --git a/share/html/Search/Bulk.html b/share/html/Search/Bulk.html
index de177c9..593309a 100644
--- a/share/html/Search/Bulk.html
+++ b/share/html/Search/Bulk.html
@@ -418,6 +418,8 @@ unless ( $ARGS{'AddMoreAttach'} ) {
 
     # Cleanup WebUI
     delete $session{'Attachments'};
+
+    $Tickets->RedoSearch();
 }
 
 my $TxnCFs = RT::CustomFields->new( $session{CurrentUser} );

-----------------------------------------------------------------------