[Rt-commit] rt branch, 4.2/default-skin, created. rt-4.2.3rc1-1-g2928add

Wallace Reis wreis at bestpractical.com
Tue Feb 18 19:54:34 EST 2014


The branch, 4.2/default-skin has been created
        at  2928addaa899efb0d11b3e5f947b29e25e05292b (commit)

- Log -----------------------------------------------------------------
commit 2928addaa899efb0d11b3e5f947b29e25e05292b
Author: Wallace Reis <wreis at bestpractical.com>
Date:   Fri Feb 14 20:41:47 2014 -0200

    Issues#29132 - Default skin is rudder, not aileron
    
    Since 4.2.0, the correct default skin is rudder.

diff --git a/lib/RT/Config.pm b/lib/RT/Config.pm
index bef4435..40dcec1 100644
--- a/lib/RT/Config.pm
+++ b/lib/RT/Config.pm
@@ -215,10 +215,10 @@ our %META;
 
             $RT::Logger->warning(
                 "The default stylesheet ($value) does not exist in this instance of RT. "
-              . "Defaulting to aileron."
+              . "Defaulting to rudder."
             );
 
-            $self->Set('WebDefaultStylesheet', 'aileron');
+            $self->Set('WebDefaultStylesheet', 'rudder');
         },
     },
     TimeInICal => {
diff --git a/t/api/config.t b/t/api/config.t
index 62b77df..b875311 100644
--- a/t/api/config.t
+++ b/t/api/config.t
@@ -1,7 +1,7 @@
 use strict;
 use warnings;
 use RT;
-use RT::Test nodb => 1, tests => 11;
+use RT::Test nodb => 1, tests => undef;
 use Test::Warn;
 
 ok(
@@ -39,5 +39,11 @@ my @encodings = qw(utf-8-strict iso-8859-1 ascii);
 warning_is {RT::Config->PostLoadCheck} "Unknown encoding 'foo' in \@EmailInputEncodings option",
   'Correct warning for encoding foo';
 
+RT::Config->Set( WebDefaultStylesheet => 'non-existent-skin-name' );
+warning_like {RT::Config->PostLoadCheck} qr{rudder},
+    'Correct warning for default stylesheet';
+
 my @canonical_encodings = RT::Config->Get('EmailInputEncodings');
 is_deeply(\@encodings, \@canonical_encodings, 'Got correct encoding list');
+
+done_testing;
\ No newline at end of file

-----------------------------------------------------------------------


More information about the rt-commit mailing list