[Rt-commit] rt branch, 4.2/user-link-mobile-ui, created. rt-4.2.3-6-g5124e18

Wallace Reis wreis at bestpractical.com
Thu Feb 27 17:32:18 EST 2014


The branch, 4.2/user-link-mobile-ui has been created
        at  5124e1874e371537cfc5b0fef46e0a9b5b5dc01d (commit)

- Log -----------------------------------------------------------------
commit 5124e1874e371537cfc5b0fef46e0a9b5b5dc01d
Author: Wallace Reis <wreis at bestpractical.com>
Date:   Fri Feb 21 14:38:46 2014 -0300

    I#28788: Mobile UI - Hide user summary links
    
    User summary link in mobile interface goes to User summary in full
    web UI, for now we are going to just hide the link instead of creating
    a mobile version of summary page.

diff --git a/share/html/Elements/ShowPrincipal b/share/html/Elements/ShowPrincipal
index 048ef6e..35afc9d 100644
--- a/share/html/Elements/ShowPrincipal
+++ b/share/html/Elements/ShowPrincipal
@@ -50,11 +50,12 @@
 $Object
 $PostUser => undef
 $Separator => ", "
+$Link => 1
 </%args>
 <%init>
 if ($Object->isa("RT::Group")) {
     # Link the users (non-recursively)
-    my @ret = map {$m->scomp("ShowPrincipal", Object => $_->[1], PostUser => $PostUser)}
+    my @ret = map {$m->scomp("ShowPrincipal", Object => $_->[1], PostUser => $PostUser, Link => $Link)}
         sort {$a->[0] cmp $b->[0]}
         map {+[($_->EmailAddress||''), $_]}
         @{ $Object->UserMembersObj( Recursively => 0 )->ItemsArrayRef };
@@ -65,7 +66,7 @@ if ($Object->isa("RT::Group")) {
 
     $m->out( join($Separator, @ret) );
 } else {
-    $m->comp("/Elements/ShowUser", User => $Object);
+    $m->comp("/Elements/ShowUser", User => $Object, Link => $Link);
     $m->out( $PostUser->($Object) ) if $PostUser;
 }
 </%init>
diff --git a/share/html/Ticket/Elements/ShowGroupMembers b/share/html/Ticket/Elements/ShowGroupMembers
index 14e6a56..f76d727 100644
--- a/share/html/Ticket/Elements/ShowGroupMembers
+++ b/share/html/Ticket/Elements/ShowGroupMembers
@@ -52,9 +52,10 @@ my $post_user = sub {
     $m->comp("/Elements/ShowUserEmailFrequency", User => $user, Ticket => $Ticket);
     $m->callback( User => $user, Ticket => $Ticket, %ARGS, CallbackName => 'AboutThisUser' );
 };
-$m->comp("/Elements/ShowPrincipal", Object => $Group, Separator => "<br />", PostUser => $post_user);
+$m->comp("/Elements/ShowPrincipal", Object => $Group, Separator => "<br />", PostUser => $post_user, Link => $Link);
 </%init>
 <%ARGS>
 $Group       => undef
 $Ticket      => undef
+$Link        => 1
 </%ARGS>
diff --git a/share/html/m/_elements/ticket_list b/share/html/m/_elements/ticket_list
index 501494c..6170fb5 100644
--- a/share/html/m/_elements/ticket_list
+++ b/share/html/m/_elements/ticket_list
@@ -91,9 +91,9 @@ loc("Found [quant,_1,ticket]",$collection->CountAll) &>
 <%perl>
 
 </%perl>
-<div class="requestors"><span class="label"><&|/l&>Requestors</&>:</span> <& /Ticket/Elements/ShowGroupMembers, Group => $ticket->Requestors, Ticket => $ticket &></div>
+<div class="requestors"><span class="label"><&|/l&>Requestors</&>:</span> <& /Ticket/Elements/ShowGroupMembers, Group => $ticket->Requestors, Ticket => $ticket, Link => 0 &></div>
 <div class="status"><span class="label"><&|/l&>Status</&>:</span> <%$ticket->Status%></div>
-<div class="owner"><span class="label"><&|/l&>Owner</&>:</span> <& /Elements/ShowUser, User => $ticket->OwnerObj, Ticket => $ticket &></div>
+<div class="owner"><span class="label"><&|/l&>Owner</&>:</span> <& /Elements/ShowUser, User => $ticket->OwnerObj, Ticket => $ticket, Link => 0 &></div>
 <div class="created"><span class="label"><&|/l&>Created</&>:</span> <%$ticket->CreatedObj->AgeAsString()%></div>
 % if ($ticket->Priority) {
 <div class="priority"><span class="label"><&|/l&>Priority</&>:</span> <%$ticket->Priority%></div>
diff --git a/share/html/m/ticket/history b/share/html/m/ticket/history
index 4293e2f..e81d830 100644
--- a/share/html/m/ticket/history
+++ b/share/html/m/ticket/history
@@ -61,7 +61,7 @@ my $history = $t->Transactions()->ItemsArrayRef;
 % for my $entry (reverse @$history) {
 <li>
 <span class="age"><% $entry->CreatedObj->AgeAsString() %></span> -
-<& /Elements/ShowUser, User => $entry->CreatorObj &> - 
+<& /Elements/ShowUser, User => $entry->CreatorObj, Link => 0 &> - 
 <%$entry->BriefDescription%>
 % if ($entry->Type !~ /EmailRecord/) {
 % if ($entry->ContentObj) {
diff --git a/share/html/m/ticket/show b/share/html/m/ticket/show
index 8cdf019..bcc7fde 100644
--- a/share/html/m/ticket/show
+++ b/share/html/m/ticket/show
@@ -284,20 +284,20 @@ my $print_value = sub {
 
  <div class="entry">
     <div class="label"><&|/l&>Owner</&>:</div>
-    <div class="value"><& /Elements/ShowUser, User => $Ticket->OwnerObj, Ticket => $Ticket &>
+    <div class="value"><& /Elements/ShowUser, User => $Ticket->OwnerObj, Ticket => $Ticket, Link => 0 &>
     </div>
   </div>
  <div class="entry">
     <div class="label"><&|/l&>Requestors</&>:</div>
-    <div class="value"><& /Ticket/Elements/ShowGroupMembers, Group => $Ticket->Requestors, Ticket => $Ticket &></div>
+    <div class="value"><& /Ticket/Elements/ShowGroupMembers, Group => $Ticket->Requestors, Ticket => $Ticket, Link => 0 &></div>
   </div>
  <div class="entry">
     <div class="label"><&|/l&>Cc</&>:</div>
-    <div class="value"><& /Ticket/Elements/ShowGroupMembers, Group => $Ticket->Cc, Ticket => $Ticket &></div>
+    <div class="value"><& /Ticket/Elements/ShowGroupMembers, Group => $Ticket->Cc, Ticket => $Ticket, Link => 0 &></div>
   </div>
  <div class="entry">
     <div class="label"><&|/l&>AdminCc</&>:</div>
-    <div class="value"><& /Ticket/Elements/ShowGroupMembers, Group => $Ticket->AdminCc, Ticket => $Ticket &></div>
+    <div class="value"><& /Ticket/Elements/ShowGroupMembers, Group => $Ticket->AdminCc, Ticket => $Ticket, Link => 0 &></div>
   </div>
 
     </&>

-----------------------------------------------------------------------


More information about the rt-commit mailing list