[Rt-commit] rt branch, 4.2/serializer-deprecation-updates, created. rt-4.2.1-157-g511f6c6

[Alex Vandiver]

The branch, 4.2/serializer-deprecation-updates has been created
        at  511f6c62ab0c50e564840ba0da7302df3afdb676 (commit)

- Log -----------------------------------------------------------------
commit ec916670356e5fb994e1c029ac6be391f27db0a5
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Jan 2 15:39:41 2014 -0500

    Remove case sensitivity on Domain to use faster indexes

diff --git a/lib/RT/Queue.pm b/lib/RT/Queue.pm
index cfaa765..1677b2f 100644
--- a/lib/RT/Queue.pm
+++ b/lib/RT/Queue.pm
@@ -1096,7 +1096,7 @@ sub FindDependencies {
 
     # Queue role groups( Cc, AdminCc )
     my $objs = RT::Groups->new( $self->CurrentUser );
-    $objs->Limit( FIELD => 'Domain', VALUE => 'RT::Queue-Role' );
+    $objs->Limit( FIELD => 'Domain', VALUE => 'RT::Queue-Role', CASESENSITIVE => 0 );
     $objs->Limit( FIELD => 'Instance', VALUE => $self->Id );
     $deps->Add( in => $objs );
 
diff --git a/lib/RT/Ticket.pm b/lib/RT/Ticket.pm
index 6c21b37..83e4095 100644
--- a/lib/RT/Ticket.pm
+++ b/lib/RT/Ticket.pm
@@ -3587,7 +3587,7 @@ sub FindDependencies {
 
     # Ticket role groups( Owner, Requestors, Cc, AdminCc )
     $objs = RT::Groups->new( $self->CurrentUser );
-    $objs->Limit( FIELD => 'Domain', VALUE => 'RT::Ticket-Role' );
+    $objs->Limit( FIELD => 'Domain', VALUE => 'RT::Ticket-Role', CASESENSITIVE => 0 );
     $objs->Limit( FIELD => 'Instance', VALUE => $self->Id );
     $deps->Add( in => $objs );
 
diff --git a/lib/RT/User.pm b/lib/RT/User.pm
index 5bb1d41..166f481 100644
--- a/lib/RT/User.pm
+++ b/lib/RT/User.pm
@@ -2672,7 +2672,7 @@ sub FindDependencies {
 
     # ACL equivalence group
     my $objs = RT::Groups->new( $self->CurrentUser );
-    $objs->Limit( FIELD => 'Domain', VALUE => 'ACLEquivalence' );
+    $objs->Limit( FIELD => 'Domain', VALUE => 'ACLEquivalence', CASESENSITIVE => 0 );
     $objs->Limit( FIELD => 'Instance', VALUE => $self->Id );
     $deps->Add( in => $objs );
 
@@ -2695,6 +2695,7 @@ sub FindDependencies {
         ALIAS => $groups,
         FIELD => 'Domain',
         VALUE => 'SystemInternal',
+        CASESENSITIVE => 0
     );
     $deps->Add( in => $objs );
 

commit 0645f80e72331b4ffdc32d5548bfbce3f70dafd6
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Jan 2 15:40:01 2014 -0500

    _SQLLimit was deprecated in favor of simple Limit

diff --git a/lib/RT/Queue.pm b/lib/RT/Queue.pm
index 1677b2f..3c78ff0 100644
--- a/lib/RT/Queue.pm
+++ b/lib/RT/Queue.pm
@@ -1135,7 +1135,7 @@ sub FindDependencies {
 
     # Tickets
     $objs = RT::Tickets->new( $self->CurrentUser );
-    $objs->_SQLLimit( FIELD => "Queue", VALUE => $self->Id );
+    $objs->Limit( FIELD => "Queue", VALUE => $self->Id );
     $objs->{allow_deleted_search} = 1;
     $deps->Add( in => $objs );
 }

commit 511f6c62ab0c50e564840ba0da7302df3afdb676
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Jan 2 15:40:19 2014 -0500

    ->LimitToRolesForSystem was deprecated in favor of >LimitToRolesForObject( RT->System )

diff --git a/lib/RT/Migrate/Serializer.pm b/lib/RT/Migrate/Serializer.pm
index 0d13b5b..23b618b 100644
--- a/lib/RT/Migrate/Serializer.pm
+++ b/lib/RT/Migrate/Serializer.pm
@@ -241,7 +241,7 @@ sub PushBasics {
 
     # System role groups
     my $systemroles = RT::Groups->new( RT->SystemUser );
-    $systemroles->LimitToRolesForSystem;
+    $systemroles->LimitToRolesForObject( RT->System );
     $self->PushObj( $systemroles );
 
     # CFs on Users, Groups, Queues

-----------------------------------------------------------------------