[Rt-commit] rt branch, 4.2/inline-server-failed-tests, repushed

[? sunnavy]

The branch 4.2/inline-server-failed-tests was deleted and repushed:
       was f2534682a5400db1cf27b760819940b7a2be461b
       now 37ca0d2fae96332ab17c07bb2783769005080dc7

1:  44fbf0a = 1:  7b37672 require actual_server since mailgate is called there
2:  f253468 ! 2:  37ca0d2 missed warnings check, which causes tests to fail in inline server mode
    @@ -1,12 +1,18 @@
     Author: sunnavy <sunnavy at bestpractical.com>
     
    -    missed one warning check, which causes tests to fail in inline server mode
    -    
    -    the error is like:
    -    
    -    Unhandled warning: Couldn't auto-create user 'conflicting' when attempting WebRemoteUser: Email address in use
    -    DESTROY created new reference to dead object 'Plack::Middleware::Test::StashWarnings' during global destruction.
    -    DESTROY created new reference to dead object 'Plack::Middleware::Test::StashWarnings' during global destruction.
    +    missed warnings check, which causes tests to fail in inline server mode
    +
    +diff --git a/t/web/path-traversal.t b/t/web/path-traversal.t
    +--- a/t/web/path-traversal.t
    ++++ b/t/web/path-traversal.t
    +@@
    + # dotfiles, for example.
    + $agent->get("$baseurl/Ticket/Attachment/28/9/.bashrc");
    + is($agent->status, 200); # Even for a file not found, we return 200
    ++$agent->next_warning_like(qr/could not be loaded/, "couldn't loaded warning");
    + $agent->content_like(qr/Attachment \S+ could not be loaded/);
    + 
    + # do not reject these URLs, even though they contain /. outside the path
     
     diff --git a/t/web/remote_user.t b/t/web/remote_user.t
     --- a/t/web/remote_user.t