[Rt-commit] rt branch, 4.2/different-result-msg-for-comment-reply, repushed

? sunnavy sunnavy at bestpractical.com
Tue Jul 8 13:28:31 EDT 2014


The branch 4.2/different-result-msg-for-comment-reply was deleted and repushed:
       was 8f1f0119ac616f7ba6147acb1e4516870d15e65a
       now 1b0c0ff0a43383ff795ef686942b2a4d25a5ffff

1:  8f1f011 ! 1:  1b0c0ff return different message for comment and reply
    @@ -4,6 +4,19 @@
         
         Old "message recorded" is confusing as it doesn't differentiate
         between correspond and comment.
    +
    +diff --git a/lib/RT/Test/GnuPG.pm b/lib/RT/Test/GnuPG.pm
    +--- a/lib/RT/Test/GnuPG.pm
    ++++ b/lib/RT/Test/GnuPG.pm
    +@@
    + 
    +     $m->click('SubmitTicket');
    +     is $m->status, 200, "request successful";
    +-    $m->content_contains("Message recorded", 'Message recorded') or diag $m->content;
    ++    $m->content_contains("Correspondence added", 'Correspondence added') or diag $m->content;
    + 
    + 
    +     my @mail = RT::Test->fetch_caught_mails;
     
     diff --git a/lib/RT/Ticket.pm b/lib/RT/Ticket.pm
     --- a/lib/RT/Ticket.pm
    @@ -52,6 +65,54 @@
          my $attachment_regex = qr/(\d+):\s+$filename/;
          expect_like($attachment_regex,"Attachment Uploaded");
     
    +diff --git a/t/web/command_line_ticket_content_type.t b/t/web/command_line_ticket_content_type.t
    +--- a/t/web/command_line_ticket_content_type.t
    ++++ b/t/web/command_line_ticket_content_type.t
    +@@
    +         qq{comment ticket/$id -ct $content_type -m bar},
    +         "commenting a ticket with content-type $content_type"
    +     );
    +-    expect_like( qr/Message recorded/, "commented the ticket" );
    ++    expect_like( qr/Comments added/, "commented the ticket" );
    + 
    +     $m->goto_ticket($id);
    +     $m->follow_link_ok( { text => 'with headers', n => 2 } );
    +
    +diff --git a/t/web/gnupg-select-keys-on-update.t b/t/web/gnupg-select-keys-on-update.t
    +--- a/t/web/gnupg-select-keys-on-update.t
    ++++ b/t/web/gnupg-select-keys-on-update.t
    +@@
    + 
    +     $m->select( 'UseKey-rt-test at example.com' => $fpr1 );
    +     $m->click('SubmitTicket');
    +-    $m->content_contains('Message recorded', 'Message recorded' );
    ++    $m->content_contains('Correspondence added', 'Correspondence added' );
    + 
    +     my @mail = RT::Test->fetch_caught_mails;
    +     ok @mail, 'there are some emails';
    +@@
    + 
    +     $m->select( 'UseKey-rt-test at example.com' => $fpr1 );
    +     $m->click('SubmitTicket');
    +-    $m->content_contains('Message recorded', 'Message recorded' );
    ++    $m->content_contains('Correspondence added', 'Correspondence added' );
    + 
    +     my @mail = RT::Test->fetch_caught_mails;
    +     ok @mail, 'there are some emails';
    +
    +diff --git a/t/web/smime/outgoing.t b/t/web/smime/outgoing.t
    +--- a/t/web/smime/outgoing.t
    ++++ b/t/web/smime/outgoing.t
    +@@
    + 
    +     $m->click('SubmitTicket');
    +     is $m->status, 200, "request successful";
    +-    $m->content_like(qr/Message recorded/, 'Message recorded');# or diag $m->content;
    ++    $m->content_like(qr/Correspondence added/, 'Correspondence added');# or diag $m->content;
    + 
    +     $m->get_ok('/'); # ensure that the mail has been processed
    + 
    +
     diff --git a/t/web/ticket_modify_all.t b/t/web/ticket_modify_all.t
     --- a/t/web/ticket_modify_all.t
     +++ b/t/web/ticket_modify_all.t



More information about the rt-commit mailing list