[Rt-commit] rt branch, 4.2/deprecate-notice-logo-size, created. rt-4.2.5-164-g567d66e

[Alex Vandiver]

The branch, 4.2/deprecate-notice-logo-size has been created
        at  567d66ebd9ccda8ea4a06509f78af3948121d4af (commit)

- Log -----------------------------------------------------------------
commit fd34dfb2588be50064a3d81465c963db810f1054
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed Jul 9 15:04:36 2014 -0400

    Allow ->Deprecated to take a loglevel

diff --git a/lib/RT.pm b/lib/RT.pm
index 6d3d5d2..238caa4 100644
--- a/lib/RT.pm
+++ b/lib/RT.pm
@@ -917,6 +917,7 @@ sub Deprecated {
         Instead => undef,
         Message => undef,
         Stack   => 1,
+        LogLevel => "warn",
         @_,
     );
 
@@ -953,7 +954,9 @@ sub Deprecated {
         if $args{Object};
 
     $msg .= "  Call stack:\n$stack" if $args{Stack};
-    RT->Logger->warn($msg);
+
+    my $loglevel = $args{LogLevel};
+    RT->Logger->$loglevel($msg);
 }
 
 =head1 BUGS

commit 567d66ebd9ccda8ea4a06509f78af3948121d4af
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed Jul 9 15:05:05 2014 -0400

    Note that LogoImageHeight and LogoImageWidth were pointless and removed

diff --git a/lib/RT/Config.pm b/lib/RT/Config.pm
index 7c75d0e..a4ede15 100644
--- a/lib/RT/Config.pm
+++ b/lib/RT/Config.pm
@@ -970,6 +970,18 @@ our %META;
     WebExternalGecos          => { Deprecated => { Instead => 'WebRemoteUserGecos',            Remove => '4.4' }},
     WebExternalAuto           => { Deprecated => { Instead => 'WebRemoteUserAutocreate',       Remove => '4.4' }},
     AutoCreate                => { Deprecated => { Instead => 'UserAutocreateDefaultsOnLogin', Remove => '4.4' }},
+    LogoImageHeight => {
+        Deprecated => {
+            LogLevel => "info",
+            Message => "The LogoImageHeight configuration option did not affect display, and has been removed; please remove it from your RT_SiteConfig.pm",
+        },
+    },
+    LogoImageWidth => {
+        Deprecated => {
+            LogLevel => "info",
+            Message => "The LogoImageWidth configuration option did not affect display, and has been removed; please remove it from your RT_SiteConfig.pm",
+        },
+    },
 );
 my %OPTIONS = ();
 my @LOADED_CONFIGS = ();

-----------------------------------------------------------------------