[Rt-commit] rt branch, 4.2/cf-grouping-anchors, created. rt-4.2.6-27-gaca8b3b

Kevin Falcone falcone at bestpractical.com
Fri Jul 25 10:24:31 EDT 2014


The branch, 4.2/cf-grouping-anchors has been created
        at  aca8b3b9cecb55072d5efc0efedbca04e7f2222a (commit)

- Log -----------------------------------------------------------------
commit aca8b3b9cecb55072d5efc0efedbca04e7f2222a
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Fri Jul 25 10:08:52 2014 -0400

    Let CF Group boxes on Display pages link to subsections of editing pages
    
    For users with a lot of CFs and subsequently a number of groups, this
    lets you jump to the right place on the page if you choose to edit a
    subset of your CFs.
    
    Closes issues #30195

diff --git a/share/html/Elements/EditCustomFieldCustomGroupings b/share/html/Elements/EditCustomFieldCustomGroupings
index 6e32436..fab851b 100644
--- a/share/html/Elements/EditCustomFieldCustomGroupings
+++ b/share/html/Elements/EditCustomFieldCustomGroupings
@@ -49,6 +49,7 @@
 <&| /Widgets/TitleBox,
     title => $group? loc($group) : loc('Custom Fields'),
     class => $css_class .' '. ($group? CSSClass("$css_class-$group") : ''),
+    ($group ? (id => CSSClass("$css_class-$group")) : ()),
     hide_empty => 1,
     %$TitleBoxARGS,
 &>
diff --git a/share/html/Elements/ShowCustomFieldCustomGroupings b/share/html/Elements/ShowCustomFieldCustomGroupings
index 262bd2d..2959be2 100644
--- a/share/html/Elements/ShowCustomFieldCustomGroupings
+++ b/share/html/Elements/ShowCustomFieldCustomGroupings
@@ -51,7 +51,7 @@ for my $group ( @Groupings ) {
         title => $group? loc($group) : loc('Custom Fields'),
         class => $css_class .' '. ($group? CSSClass("$css_class-$group") : ''),
         hide_empty => 1,
-        title_href => $title_href ? "$title_href?id=".$Object->id.($group?";Grouping=".$m->interp->apply_escapes($group, 'u'):"") : undef,
+        title_href => $title_href ? "$title_href?id=".$Object->id.($group?";Grouping=".$m->interp->apply_escapes($group,'u')."#".CSSClass("$css_class-$group") : '') : undef,
         %$TitleBoxARGS,
     );
     $m->callback( CallbackName => 'TitleBox', Object => $Object, Grouping => $group, ARGSRef => \%grouping_args );

-----------------------------------------------------------------------


More information about the rt-commit mailing list