[Rt-commit] rt branch, 4.4/squelching-all, repushed

[Wallace Reis]

The branch 4.4/squelching-all was deleted and repushed:
       was c87fc36f866a7d5941b87b08f60714fa0187a98e
       now 95bb6f37b13fda4e26e026d3b1c8171e50c8cabd

 1:  098c568 =  1:  098c568 ajaxify PrviewScrips and ShowSimplifiedRecipients on ticket update page
 2:  df919d2 =  2:  df919d2 Pass the just-submitted squelching information to the first AJAX request
 3:  e9df999 =  3:  e9df999 Sync the ckeditor output before updating messages
 4:  910a666 =  4:  910a666 Roll back on failure to Comment, as Correspond does
 5:  a25d722 =  5:  a25d722 DryRun now wraps in a rollback, and records all transactions
 6:  aacb253 =  6:  aacb253 Display all scrips which are triggered
 7:  9c47817 =  7:  9c47817 Re-use squelching information for future updates to a ticket in same request
 8:  d0fc383 =  8:  d0fc383 Remove mostly-duplicate code for Rules which can never trigger
 9:  6f606a1 !  9:  f70de0a Add squelched recipients as preference
    @@ -3,7 +3,7 @@
         Add squelched recipients as preference
         
         User preference to start with squelch checkboxes unchecked/checked on
    -    ticket reply page. This should respect the semi-permanetly squelched
    +    ticket reply page. This should respect the semi-permanently squelched
         address when applying its logic. If set to true, then the page shows
         the checkboxes unchecked - which means the email addresses are *not*
         getting any kind of mail.
    @@ -21,7 +21,8 @@
     +
     +If C<$SquelchedRecipients> is set, the checkbox list of who will receive
     +B<any> kind of mail on the ticket reply page are displayed initially as
    -+B<un>checked - which means nobody in that list would get any mail.
    ++B<un>checked - which means nobody in that list would get any mail. It
    ++does not affect correspondence done via email yet.
     +
     +=cut
     +
    @@ -44,7 +45,7 @@
     +        SortOrder       => 8,
     +        Widget          => '/Widgets/Form/Boolean',
     +        WidgetArguments => {
    -+            Description => "Start with squelch checkboxes unchecked/checked on ticket update", #loc
    ++            Description => "Default to squelching all outgoing email notifications (from WebUI) on ticket update", #loc
     +        },
     +    },
          DisplayTicketAfterQuickCreate => {
10:  526545d ! 10:  7215741 'Select All' checkbox for scrips correspondences/comments
    @@ -10,6 +10,14 @@
     --- a/share/html/Helpers/PreviewScrips
     +++ b/share/html/Helpers/PreviewScrips
     @@
    + $m->abort unless @dryrun;
    + 
    + my %squelched = ProcessTransactionSquelching( \%ARGS );
    ++use Data::Dumper; warn Dumper(\%squelched);
    + </%init>
    + <p>
    + <&|/l, RT->Config->Get('WebPath')."/Ticket/ModifyPeople.html?id=".$TicketObj->Id,
    +@@
      % my @scrips = grep {$_->ActionObj->Action->isa('RT::Action::SendEmail')}
      %              map {@{$_->Scrips->Prepared}} @dryrun;
      % if (@scrips) {
    @@ -18,7 +26,7 @@
     +%          my $action = $s->ActionObj->Action;
     +%          scalar(map { $action->$_ } qw(To Cc Bcc))
     +%        } @scrips ) {
    -+<input type="checkbox" name="TxnSendMailToAll" value="1" checked="checked" onclick="setCheckbox(this,'TxnSendMailTo')">
    ++<input type="checkbox" class="checkbox" name="TxnSendMailToAll" value="1" checked="checked" onclick="setCheckbox(this,'TxnSendMailTo')">
     +<label for="TxnSendMailToAll"><b><% loc('All recipients') %></b></label><br />
     +%   }
      %     for my $scrip (@scrips) {
    @@ -36,7 +44,7 @@
     +<tr>
     +<td> </td>
     +<td>
    -+<input type="checkbox" name="TxnSendMailToAll" value="1" checked="checked" onclick="setCheckbox(this,'TxnSendMailTo')">
    ++<input type="checkbox" class="checkbox" name="TxnSendMailToAll" value="1" checked="checked" onclick="setCheckbox(this,'TxnSendMailTo')">
     +<label for="TxnSendMailToAll"><b><% loc('All recipients') %></b></label>
     +</td>
     +</tr>
11:  c87fc36 = 11:  95bb6f3 Make 'select all' check/uncheck bi-directional