[Rt-commit] rt branch, 4.2/record-attachments-dropping, repushed

[? sunnavy]

The branch 4.2/record-attachments-dropping was deleted and repushed:
       was 1289ddecffc961dcd28b012725196f56fc5c6079
       now a3aaa712f8905cd4620f6b7c5b9183e4a3c90dc8

1:  c610009 = 1:  c610009 record attachments' dropping/truncation as txns
2:  338128d ! 2:  216dedf test attachment dropping/truncation
    @@ -109,7 +109,7 @@
     +
     +$m->content_contains( "$name truncated because its size (1010 bytes) exceeded configured maximum size setting (1000 bytes).", 'truncated message' );
     +$m->content_contains( 'cf' . 'a' x 998, 'has the first 1000 cf chars' );
    -+$m->content_lacks( 'cfb', 'lacks cf chars after that' );
    ++$m->content_lacks( 'aaacfb', 'lacks cf chars after that' );
     +$m->follow_link_ok( { text => "Download $name" } );
     +$m->content_contains( 'a' x 1000, 'has the first 1000 chars' );
     +$m->content_lacks( 'b', 'lacks chars after that' );
3:  5f6aebe ! 3:  8fc4cff make attachment truncate/drop and error txns more noticeable
    @@ -2,7 +2,7 @@
     
         make attachment truncate/drop and error txns more noticeable
         
    -    usually we could choose red, but we already have similar color(#b32) there.
    +    color scheme is from cloos++
     
     diff --git a/lib/RT/Record.pm b/lib/RT/Record.pm
     --- a/lib/RT/Record.pm
    @@ -21,13 +21,13 @@
     --- a/share/static/css/base/history.css
     +++ b/share/static/css/base/history.css
     @@
    - .transaction.message .type { background: #069; }
      .transaction.reminders .type { background: #369; }
      .transaction.other .type { background: #abc; }
    --.transaction.error .type { background: #abc; }
    -+.transaction.error .type { background: #f0ad4e; }
    -+.transaction.attachment-truncate .type { background: #f0ad4e; }
    -+.transaction.attachment-drop .type { background: #f0ad4e; }
    + .transaction.error .type { background: #abc; }
    ++.transaction.attachment-truncate .type, .transaction.attachment-drop .type { background-color: #abc; }
    ++
    ++.transaction.error { background-color: #fcc; }
    ++.transaction.attachment-truncate, .transaction.attachment-drop { background-color: #ffc; }
      
      
      .transaction .message-header-value.verify { font-weight: bold; }
4:  1289dde ! 4:  a3aaa71 refactor email sent failure system error txn to use the same tech as Attachment Truncate/Drop.
    @@ -30,12 +30,7 @@
          SystemError => sub {
              my $self = shift;
     -        return ("System error"); #loc()
    -+        if ( defined $self->Data && $self->Data ne 'No Subject' ) {
    -+            return $self->Data;
    -+        }
    -+        else {
    -+            return ("System error"); #loc()
    -+        }
    ++        return $self->Data // ("System error"); #loc()
          },
          AttachmentTruncate => sub {
              my $self = shift;