[Rt-commit] [rtir] 01/01: Remove misleading note about which IRs are counted

[Kevin Falcone]

This is an automated email from the git hooks/post-receive script.

falcone pushed a commit to branch 3.0-trunk
in repository rtir.

commit 3131f5a8d6be91f9c2ed8e5e611c10b861cc287c
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Fri Jun 6 16:19:42 2014 -0400

    Remove misleading note about which IRs are counted
    
    When this line was introduced in RTIR 1 in 5892d273 the message only
    showed up in the tabbed output, but the code did correctly handle IRs
    without Incidents (although it meant that it wouldn't even consider the
    Constituency field on the IR itself which is.. odd).
    
    When this code was refactored in 0553622 it took some very simple logic
    and replaced it with clever and wrong code that failed to consider the
    fact that a subroutine was returning undef as a special "No linked
    Incident" case.
    
    next unless ($value eq $Constituency || !defined $value);
    became the "failing to consider undef"
    delete $res->{$id} if !$value || $value ne $condition;
    even the current code which uses a ternary operator gets undef wrong and
    can only count unlinked IRs with the yet-to-be-merged branch that allows
    Constituency to be optional.
    
    While it's straightforward to return the original behavior, it's been
    broken since 2.4.0 was released, so we won't fix it in
    3.0-trunk.  End goal is that RTIR should get enough of RT's reporting to
    not need this thing anymore.
---
 html/RTIR/Reporting/Report.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/html/RTIR/Reporting/Report.html b/html/RTIR/Reporting/Report.html
index ae492bb..2770bfa 100644
--- a/html/RTIR/Reporting/Report.html
+++ b/html/RTIR/Reporting/Report.html
@@ -54,7 +54,7 @@ $m->comp("SELF:TwoColumnsTable$ReportAs",
     ]
 );
 $m->comp("SELF:TwoColumnsTable$ReportAs",
-    Title => loc('Incident Report Summary (including unlinked Incident Reports)'),
+    Title => loc('Incident Report Summary'),
     Body  => [
         [ loc('Outstanding reports at the beginning of this period'), scalar keys %$outstanding_pruned ],
         [ loc('Total new reports for this period'), scalar keys %$tix_created_pruned ],

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.